-
Notifications
You must be signed in to change notification settings - Fork 69
all: vm use uint256 #28598 #1977
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev-upgrade
Are you sure you want to change the base?
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR migrates the EVM's internal value representation from *big.Int to *uint256.Int to improve performance by reducing allocations and avoiding unnecessary type conversions. This change aligns with the broader Ethereum ecosystem's move towards using uint256 for better efficiency in VM operations.
Changes:
- Updated VM function signatures to accept
*uint256.Intinstead of*big.Intfor value parameters - Modified contract value field from
*big.Intto*uint256.Int - Simplified VM instruction implementations by removing redundant conversions
- Updated all test files to use uint256.Int types
- Added conversions at boundaries where interfaces still expect big.Int (tracers, state transfers)
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| core/vm/contract.go | Changed Contract.value field type to *uint256.Int and updated NewContract signature |
| core/vm/evm.go | Updated Call, CallCode, Create, Create2 signatures to use *uint256.Int; added .ToBig() conversions at state/tracer boundaries |
| core/vm/instructions.go | Simplified opCallValue, opCreate, opCreate2, opCall, opCallCode by removing unnecessary conversions; removed unused big.Int import |
| core/vm/interpreter.go | Updated CallValue() return type to *uint256.Int; removed big.Int import |
| core/vm/instructions_test.go | Updated test to use new(uint256.Int) for contract creation |
| core/vm/gas_table_test.go | Updated tests to use new(uint256.Int) for EVM calls |
| core/vm/runtime/runtime.go | Added uint256.MustFromBig conversions when calling EVM functions |
| core/tracing/hooks.go | Updated OpContext.CallValue interface to return *uint256.Int |
| core/state_transition.go | Uses value variable (already uint256.Int from conversion) for EVM calls |
| tests/vm_test_util.go | Updated to use uint256.MustFromBig for test execution |
| eth/tracers/logger/logger_test.go | Updated test contract creation to use new(uint256.Int) |
| eth/tracers/js/tracer_test.go | Updated tests to use new(uint256.Int) and convert back to big.Int for tracer calls |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
57624df to
97d9734
Compare
97d9734 to
74e0235
Compare
74e0235 to
2bfe7f9
Compare
Proposed changes
This is the successor of PR #1240. According to the issue #1242, we assume that the balance will overflow, so we keep the type of balance as
big.Intin this PR.Ref: ethereum#28598
Types of changes
What types of changes does your code introduce to XDC network?
Put an
✅in the boxes that applyImpacted Components
Which part of the codebase this PR will touch base on,
Put an
✅in the boxes that applyChecklist
Put an
✅in the boxes once you have confirmed below actions (or provide reasons on not doing so) that