Skip to content

Conversation

@gzliudan
Copy link
Collaborator

@gzliudan gzliudan commented Jan 22, 2026

Proposed changes

This is the successor of PR #1240. According to the issue #1242, we assume that the balance will overflow, so we keep the type of balance as big.Int in this PR.

Ref: ethereum#28598

Types of changes

What types of changes does your code introduce to XDC network?
Put an in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)
  • Regular KTLO or any of the maintaince work. e.g code style
  • CICD Improvement

Impacted Components

Which part of the codebase this PR will touch base on,

Put an in the boxes that apply

  • Consensus
  • Account
  • Network
  • Geth
  • Smart Contract
  • External components
  • Not sure (Please specify below)

Checklist

Put an in the boxes once you have confirmed below actions (or provide reasons on not doing so) that

  • This PR has sufficient test coverage (unit/integration test) OR I have provided reason in the PR description for not having test coverage
  • Provide an end-to-end test plan in the PR description on how to manually test it on the devnet/testnet.
  • Tested the backwards compatibility.
  • Tested with XDC nodes running this version co-exist with those running the previous version.
  • Relevant documentation has been updated as part of this PR
  • N/A

Copilot AI review requested due to automatic review settings January 22, 2026 09:27
@coderabbitai
Copy link

coderabbitai bot commented Jan 22, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@gzliudan gzliudan changed the title all: vm use uint256 #28598 [WIP] all: vm use uint256 #28598 Jan 22, 2026
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR migrates the EVM's internal value representation from *big.Int to *uint256.Int to improve performance by reducing allocations and avoiding unnecessary type conversions. This change aligns with the broader Ethereum ecosystem's move towards using uint256 for better efficiency in VM operations.

Changes:

  • Updated VM function signatures to accept *uint256.Int instead of *big.Int for value parameters
  • Modified contract value field from *big.Int to *uint256.Int
  • Simplified VM instruction implementations by removing redundant conversions
  • Updated all test files to use uint256.Int types
  • Added conversions at boundaries where interfaces still expect big.Int (tracers, state transfers)

Reviewed changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated no comments.

Show a summary per file
File Description
core/vm/contract.go Changed Contract.value field type to *uint256.Int and updated NewContract signature
core/vm/evm.go Updated Call, CallCode, Create, Create2 signatures to use *uint256.Int; added .ToBig() conversions at state/tracer boundaries
core/vm/instructions.go Simplified opCallValue, opCreate, opCreate2, opCall, opCallCode by removing unnecessary conversions; removed unused big.Int import
core/vm/interpreter.go Updated CallValue() return type to *uint256.Int; removed big.Int import
core/vm/instructions_test.go Updated test to use new(uint256.Int) for contract creation
core/vm/gas_table_test.go Updated tests to use new(uint256.Int) for EVM calls
core/vm/runtime/runtime.go Added uint256.MustFromBig conversions when calling EVM functions
core/tracing/hooks.go Updated OpContext.CallValue interface to return *uint256.Int
core/state_transition.go Uses value variable (already uint256.Int from conversion) for EVM calls
tests/vm_test_util.go Updated to use uint256.MustFromBig for test execution
eth/tracers/logger/logger_test.go Updated test contract creation to use new(uint256.Int)
eth/tracers/js/tracer_test.go Updated tests to use new(uint256.Int) and convert back to big.Int for tracer calls

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@gzliudan gzliudan changed the title [WIP] all: vm use uint256 #28598 all: vm use uint256 #28598 Jan 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant