verifyimage: Fix segmentation fault that occurs during verifyimage. #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In commit d02322b, the behavior of ReadBinaryFile was changed such that it no longer populated iHT. This caused VerifyAuthentication to access a null iHT value resulting a segementation fault. This fix changes VerifyAuthentication to call ReadHeaderTableDetails instead, where the old functionality of ReadBinaryFile now lives. Signed-off-by: Charlie Johnston <charlie.johnston@loftorbital.com>
|
Thanks, I'm seeing this as well. Notice that it was fixed differently in the 2024.1 dump by making ReadBinaryFile() call ReadHeaderTableDetails(): 3a0f879#diff-404aa20e03f1035b725ac1ea6e64c28477bb65c1663da67f64ffdb1a60552cee |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In commit d02322b, the behavior of ReadBinaryFile was changed such that it no longer populated iHT. This caused VerifyAuthentication to access a null iHT value resulting a segementation fault.
This fix changes VerifyAuthentication to call ReadHeaderTableDetails instead, where the old functionality of ReadBinaryFile now lives.