Draft
Conversation
Collaborator
|
Nice, we've been meaning to add this for ages. Before I review, I'd change the main tests so that they take an option to create a file with tmpfile + link, and then run them with that option and check that things are fine. And I'd also just add a very basic test that checks if that works. |
mcrnic
reviewed
Dec 2, 2025
mcrnic
requested changes
Dec 2, 2025
Collaborator
mcrnic
left a comment
There was a problem hiding this comment.
You have some bugs around dget_parent dput
Issues:
- you call
dget_parentin ternfs_link but it will not be put ifflush_and_linkerrors - you don't call
dget_parentinternfs_file_flushbut then you dodputinflush_and_linkif it does not errors
Collaborator
Author
|
made it always dget/dput the parent |
Collaborator
Author
|
ah i think i can scope it better |
mcrnic
approved these changes
Dec 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this implements .tmpfile and .link
it also abstracts the common path of flushing and linking into a helper function