Conversation
…close Tun in tun.Handler
Member
Author
|
Got tests on Linux, and while
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes broken chain of
Close()calls on TUN inbound.On Windows this fixes dangling adapter after calling
Close()onInstance, and, strangely, fixes timeout on first attempt to create adapter again after application reboot.On Linux nothing technically changes (I'm not really sure if
Tun.Start()is called byAlwaysOnInboundHandler)On Darwin, Android and iOS nothing changes because they have empty
Close()implementations.