Skip to content

Conversation

@ggoffy
Copy link
Contributor

@ggoffy ggoffy commented Jan 12, 2026

No description provided.

@ggoffy ggoffy requested a review from mambax7 January 12, 2026 21:53
@mambax7
Copy link
Collaborator

mambax7 commented Jan 12, 2026

Thanks for the submission. Actually, the change will be:

xoops_setcookie('xo_upgrade_lang', $upgrade_language, 0, '', '');

but I didn't commit it yet.

I'll approve yours right now, and then update it with the rest of the stuff that I'm working on.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a type error in the upgrade process by correcting the xoops_setcookie function call to use proper type-safe parameters. The xoops_setcookie function signature was modernized with strict type hints, requiring the $expire parameter to be an int rather than null.

Changes:

  • Updated the xoops_setcookie call in the upgrade language determination logic to pass 0 instead of null for the expire parameter

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@mambax7 mambax7 merged commit e5e17e4 into XOOPS:master Jan 12, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants