796: allow ${instanceID} reference for longitudinal / entities workflows #805
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add tests for related instance_id / instanceID behaviour
- existing test_create_repeat asserts via xpe.model_instance_meta that
the entity meta group doesn't contain an instanceID element.
lindsay-stevens
force-pushed
the
pyxform-796
branch
from
322b911 to
431f49c
Compare
Contributor
I either never knew about these or forgot about them. As far as I know, servers will typically reject forms without |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #796
Why is this the best possible solution? Were any other approaches considered?
This adds
instanceIDto the list of allowed element names that can be referenced with${}. This is a key part of entity use cases mentioned in #796.Considered not covering the related but undocumented / untested settings
instance_idandomit_instanceID, but they impact this feature and may be in use, and could be removed separately.What are the regression risks?
Fixes a regression. If a question named
instanceIDexists, that is still allowed, but if a reference to${instanceID}is added, that will raise an error due to a duplicate name - which is the current release behaviour.Does this change require updates to documentation? If so, please file an issue here and include the link below.
Yes, filed here.
Before submitting this PR, please make sure you have:
testspython -m unittestand verified all tests passruff format pyxform testsandruff check pyxform teststo lint code