Conversation
There was a problem hiding this comment.
Pull request overview
Prepares the Java library for the next release by moving the build/tooling baseline to Java 21 and incrementing the Maven revision used for publishing artifacts.
Changes:
- Bump Maven
revisionfrom0.3+worklytics.12to0.3+worklytics.13. - Update Maven compiler settings from Java 17 to Java 21.
- Update GitHub Actions Java test workflow to run on Java 21; remove the old version-specific POM file.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
java/pom.xml |
Version bump via revision property and compiler source/target updated to 21. |
java/appengine-pipeline-0.3+worklytics.12-pom.xml |
Removes the old, version-pinned POM file from the repo. |
.github/workflows/test-java.yml |
CI compilation/test jobs now run using Java 21. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| <plugin> | ||
| <groupId>org.apache.maven.plugins</groupId> | ||
| <artifactId>maven-compiler-plugin</artifactId> | ||
| <version>3.13.0</version> | ||
| <configuration> | ||
| <source>17</source> | ||
| <target>17</target> | ||
|
|
||
| <source>21</source> | ||
| <target>21</target> | ||
| </configuration> |
There was a problem hiding this comment.
PR description mentions "new mvn plugins", but the only Maven-related change in this diff is updating compiler source/target to 21. If additional plugin updates were intended, they may be missing from the PR description or from the actual changes—please align the description with what’s being shipped.
| <source>21</source> | ||
| <target>21</target> |
There was a problem hiding this comment.
Consider using the maven-compiler-plugin <release>21</release> setting instead of <source>/<target>. <release> ensures the correct JDK API level is used during compilation (and avoids accidental linkage against newer JDK classes when building on newer toolchains).
| <source>21</source> | |
| <target>21</target> | |
| <release>21</release> |
.github/workflows/test-java.yml
Outdated
| distribution: 'adopt' | ||
| java-version: '17' # maven won't accept --release argument with java < 8; and 11 is next LTS | ||
| java-version: '21' # maven won't accept --release argument with java < 8; and 11 is next LTS |
There was a problem hiding this comment.
The inline comment about the Java version is outdated/misleading now that this is set to 21 (e.g., it mentions Java 11 being the next LTS and discusses --release, which this workflow doesn't use). Please update or remove the comment to reflect the current setup.
| distribution: 'adopt' | ||
| java-version: '17' # maven won't accept --release argument with java < 8; and 11 is next LTS | ||
| java-version: '21' # maven won't accept --release argument with java < 8; and 11 is next LTS |
There was a problem hiding this comment.
The inline comment about the Java version is outdated/misleading now that this is set to 21 (e.g., it mentions Java 11 being the next LTS and discusses --release, which this workflow doesn't use). Please update or remove the comment to reflect the current setup.
Features
Change implications