Handle removed dart style cli option by robbecker-wf · Pull Request #466 · Workiva/dart_dev

robbecker-wf · 2026-03-13T22:02:17Z

Summary

Working on adding support for configuring the language version in the FormatTool as well as not trying to pass the removed -w command when running dart_style directly

robbecker-wf · 2026-03-15T18:08:23Z

lib/src/tools/format_tool.dart

  ArgResults? argResults,
  List<String>? configuredFormatterArgs,
+  bool passWriteArgForOverwrite = true,
+  String? languageVersion,


here's a non-formatting change

robbecker-wf · 2026-03-15T18:08:41Z

lib/src/tools/format_tool.dart

      defaultMode: defaultMode,
      exclude: exclude,
      formatter: formatter,
+      languageVersion: languageVersion,


here's a non-formatting change

robbecker-wf · 2026-03-15T18:08:54Z

lib/src/tools/format_tool.dart

+  /// `--language-version`.
+  ///
+  /// If null, `latest` will be used when dart_dev decides the flag is needed.
+  String? languageVersion;


here's a non-formatting change

robbecker-wf · 2026-03-15T18:09:28Z

lib/src/tools/format_tool.dart

+  FormatMode? mode, {
+  ArgResults? argResults,
+  List<String>? configuredFormatterArgs,
+  String? languageVersion,


here's a non-formatting change. added languageVersion

robbecker-wf · 2026-03-15T18:09:39Z

lib/src/tools/format_tool.dart

    // 1. Mode flag(s), if configured
    if (mode == FormatMode.check) ...['-o', 'none', '--set-exit-if-changed'],
    if (mode == FormatMode.dryRun) ...['-o', 'none'],
+    if (languageVersion != null) '--language-version=$languageVersion',


here's a non-formatting change

robbecker-wf · 2026-03-15T18:09:48Z

lib/src/tools/format_tool.dart

  FormatMode? defaultMode,
  List<Glob>? exclude,
  Formatter? formatter,
+  String? languageVersion,


here's a non-formatting change

robbecker-wf · 2026-03-15T18:10:42Z

lib/src/tools/format_tool.dart

+    formatter,
+    dartStyleSupportsWriteArg,
+    configuredLanguageVersion: languageVersion,
+  );


here's a non-formatting change. determine if we should use -w and what the language version to use is.

robbecker-wf · 2026-03-15T18:11:12Z

lib/src/tools/format_tool.dart

+      mode,
+      argResults: context.argResults,
+      configuredFormatterArgs: configuredFormatterArgs,
+      languageVersion: formatterLanguageVersion,


pass in the language version

robbecker-wf · 2026-03-15T18:11:34Z

lib/src/tools/format_tool.dart

+      argResults: context.argResults,
+      configuredFormatterArgs: configuredFormatterArgs,
+      passWriteArgForOverwrite: dartStyleSupportsWriteArg,
+      languageVersion: formatterLanguageVersion,


pass in language version and -w usage

robbecker-wf · 2026-03-15T18:12:29Z

lib/src/tools/format_tool.dart

@@ -515,14 +580,99 @@ ProcessDeclaration buildFormatProcess([Formatter? formatter]) {
  }
 }



new util methods

robbecker-wf · 2026-03-15T18:12:41Z

lib/src/tools/format_tool.dart

 ///
 /// Unless [verbose] is true, the list of inputs will be abbreviated to avoid an
 /// unnecessarily long log.
 void logCommand(


the rest is formatting below here

robbecker-wf · 2026-03-15T18:13:13Z

lib/src/tools/function_tool.dart

@@ -13,10 +13,10 @@ import '../utils/assert_no_positional_args_nor_args_after_separator.dart';
 /// Use [DevTool.fromFunction] to create [FunctionTool] instances.
 class FunctionTool extends DevTool {


only formatting changes in this file

robbecker-wf · 2026-03-15T18:13:37Z

lib/src/tools/over_react_format_tool.dart

@@ -28,19 +28,22 @@ class OverReactFormatTool extends DevTool {
    Iterable<String> paths = context.argResults?.rest ?? [];


only formatting changes in this file

robbecker-wf · 2026-03-15T18:13:52Z

lib/src/tools/process_tool.dart

@@ -27,12 +27,15 @@ final _log = Logger('Process');
 /// It is also possible to run this tool directly in a dart script:
 ///     ProcessTool(exe, args).run();
 class ProcessTool extends DevTool {


only formatting changes in this file

robbecker-wf · 2026-03-15T18:14:00Z

lib/src/tools/test_tool.dart

@@ -50,48 +50,66 @@ class TestTool extends DevTool {
  @override
  final ArgParser argParser = ArgParser()
    ..addSeparator('======== Selecting Tests')


only formatting changes in this file

robbecker-wf · 2026-03-15T18:14:30Z

lib/src/tools/tuneup_check_tool.dart

@@ -54,13 +54,16 @@ class TuneupCheckTool extends DevTool {
    ..addFlag('ignore-infos', help: 'Ignore any info level issues.');

  @override


only formatting changes in this file

robbecker-wf · 2026-03-15T18:14:39Z

lib/src/tools/webdev_serve_tool.dart

@@ -64,27 +64,40 @@ class WebdevServeTool extends DevTool {

  @override
  final ArgParser argParser = ArgParser()


only formatting changes in this file

robbecker-wf · 2026-03-15T19:03:26Z

test/tools/fixtures/format/has_dart_style_v2/pubspec.yaml

@@ -0,0 +1,4 @@
+name: has_dart_style_v2


new test fixture

robbecker-wf · 2026-03-15T19:03:32Z

test/tools/fixtures/format/has_dart_style_v3/pubspec.yaml

@@ -0,0 +1,4 @@
+name: has_dart_style_v3


new test fixture

robbecker-wf · 2026-03-15T19:05:19Z

test/tools/format_tool_test.dart

-          orderedEquals(['a', 'b', '-w']));
+      expect(
+        buildArgs(['a', 'b'], FormatMode.overwrite),
+        orderedEquals(['a', 'b', '-w']),


test with -w

robbecker-wf · 2026-03-15T19:05:27Z

test/tools/format_tool_test.dart

+      );
+    });
+
+    test('mode=overwrite without write arg', () {


test without -w

robbecker-wf · 2026-03-15T19:06:09Z

test/tools/format_tool_test.dart

+      );
+    });
+
+    test('adds latest language version flag when configured', () {


2 tests to test the new language version config

robbecker-wf · 2026-03-15T19:07:00Z

test/tools/format_tool_test.dart

+      );
+    });
+
+    test('adds latest language version flag when configured', () {


2 new tests

robbecker-wf · 2026-03-15T19:10:14Z

test/tools/format_tool_test.dart

        expect(execution.directiveOrganization, isNull);
      });

+      test(


new tests for dart_style

robbecker-wf · 2026-03-15T19:11:04Z

test/tools/format_tool_test.dart

+        final execution = buildExecution(
+          context,
+          configuredFormatterArgs: ['--fix', '--follow-links'],
+          formatter: Formatter.dartFormat,


updates to test for language version under dart 3

robbecker-wf · 2026-03-15T19:11:56Z

test/tools/format_tool_test.dart

    test('<=5 inputs and verbose=false', () async {
-      expect(Logger.root.onRecord,
-          emitsThrough(infoLogOf(contains('dartfmt -x -y a b'))));
+      expect(


format changes below

robbecker-wf · 2026-03-15T19:15:01Z

test/utils/format_tool_builder_test.dart

+          );
+        });
+
+        test('detects languageVersion', () {


robbecker-wf · 2026-03-15T19:15:23Z

test/utils/format_tool_builder_test.dart

-String formatToolCascadeSrc({String formatter = 'dartfmt'}) =>
+String formatToolCascadeSrc({
+  String formatter = 'dartfmt',
+  String? languageVersion,


add language version

robbecker-wf · 2026-03-15T19:16:43Z

test/functional/format_tool_functional_test.dart

      );
    });
+
+    test(


robbecker-wf · 2026-03-15T19:17:34Z

test/functional/fixtures/format/language_version/dart_format_configured/lib/main.dart

@@ -0,0 +1,3 @@
+void main() {


new test fixture

robbecker-wf · 2026-03-15T19:19:03Z

lib/src/utils/format_tool_builder.dart

+            );
+          }
+        }
+


get the language version from config

robbecker-wf · 2026-03-15T19:19:37Z

lib/src/utils/format_tool_builder.dart

  failedToReconstructFormatterArgs,
  failedToParseFormatterArgs,
  failedToParseLineLength,
+  failedToParseLanguageVersion,


robbecker-wf · 2026-03-15T19:20:46Z

lib/src/utils/pubspec_lock.dart

+    }
+  }
+  return null;
+}


new util function

robbecker-wf added 2 commits March 13, 2026 15:40

Dart format updates for dart_style 3+

7647597

language version is configurable

d377e60

btr-rmconsole-1 bot added the Merge Requirements Unmet label Mar 13, 2026

robbecker-wf added 2 commits March 13, 2026 16:06

dart 3 format

cb3e16e

fix slashes for windows

5a25474

robbecker-wf commented Mar 15, 2026

View reviewed changes

test/tools/fixtures/format/has_dart_style_v2/pubspec.yaml

@@ -0,0 +1,4 @@

name: has_dart_style_v2

Copy link

Member Author

robbecker-wf Mar 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new test fixture

robbecker-wf commented Mar 15, 2026

View reviewed changes

test/tools/fixtures/format/has_dart_style_v3/pubspec.yaml

@@ -0,0 +1,4 @@

name: has_dart_style_v3

Copy link

Member Author

robbecker-wf Mar 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new test fixture

robbecker-wf commented Mar 15, 2026

View reviewed changes

test/tools/format_tool_test.dart

);

});

test('mode=overwrite without write arg', () {

Copy link

Member Author

robbecker-wf Mar 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test without -w

robbecker-wf commented Mar 15, 2026

View reviewed changes

test/tools/format_tool_test.dart

);

});

test('adds latest language version flag when configured', () {

Copy link

Member Author

robbecker-wf Mar 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 new tests

robbecker-wf commented Mar 15, 2026

View reviewed changes

test/tools/format_tool_test.dart

expect(execution.directiveOrganization, isNull);

});

test(

Copy link

Member Author

robbecker-wf Mar 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new tests for dart_style

robbecker-wf commented Mar 15, 2026

View reviewed changes

test/utils/format_tool_builder_test.dart

);

});

test('detects languageVersion', () {

Copy link

Member Author

robbecker-wf Mar 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new test

robbecker-wf commented Mar 15, 2026

View reviewed changes

test/functional/format_tool_functional_test.dart

);

});

test(

Copy link

Member Author

robbecker-wf Mar 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new test

robbecker-wf commented Mar 15, 2026

View reviewed changes

lib/src/utils/format_tool_builder.dart

);

}

}

Copy link

Member Author

robbecker-wf Mar 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

get the language version from config

robbecker-wf commented Mar 15, 2026

View reviewed changes

lib/src/utils/pubspec_lock.dart

}

}

return null;

}

Copy link

Member Author

robbecker-wf Mar 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new util function

		@@ -515,14 +580,99 @@ ProcessDeclaration buildFormatProcess([Formatter? formatter]) {
		}
		}

		@@ -13,10 +13,10 @@ import '../utils/assert_no_positional_args_nor_args_after_separator.dart';
		/// Use [DevTool.fromFunction] to create [FunctionTool] instances.
		class FunctionTool extends DevTool {

		@@ -28,19 +28,22 @@ class OverReactFormatTool extends DevTool {
		Iterable<String> paths = context.argResults?.rest ?? [];

		@@ -54,13 +54,16 @@ class TuneupCheckTool extends DevTool {
		..addFlag('ignore-infos', help: 'Ignore any info level issues.');

		@override

		@@ -64,27 +64,40 @@ class WebdevServeTool extends DevTool {

		@override
		final ArgParser argParser = ArgParser()

                     );
                   });
+                  test(

Conversation

robbecker-wf commented Mar 13, 2026

Summary

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant