Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion api/includes.go
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ func (i Includes) initialiseMap(include *kyaml.RNode) {
}
}

// toMap converts a kyaml.RNode YAML contento to a map[string]interface{}.
// toMap converts a kyaml.RNode YAML content to a map[string]interface{}.
func toMap(include *kyaml.RNode) (map[string]interface{}, error) {
marshalled, err := include.MarshalJSON()
if err != nil {
Expand Down
99 changes: 99 additions & 0 deletions api/krm_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,11 @@ import (
"testing"

"github.com/Workday/cuestomize/internal/pkg/testhelpers"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
"sigs.k8s.io/kustomize/api/types"
"sigs.k8s.io/kustomize/kyaml/resid"
kyaml "sigs.k8s.io/kustomize/kyaml/yaml"
)

const (
Expand Down Expand Up @@ -63,3 +67,98 @@ func TestKRMInput_ExtractIncludes(t *testing.T) {
})
}
}

func TestFindAuthSecret(t *testing.T) {
tests := []struct {
name string
selector types.Selector
items []*kyaml.RNode
expectedName string
expectedError string
}{
{
name: "selector kind is not Secret",
selector: types.Selector{
ResId: resid.ResId{
Gvk: resid.Gvk{Kind: "ConfigMap"},
},
},
items: []*kyaml.RNode{},
expectedError: `kind must be Secret, got: "ConfigMap"`,
},
{
name: "secret not found",
selector: types.Selector{
ResId: resid.ResId{
Gvk: resid.Gvk{Kind: "Secret"}, Name: "my-secret",
},
},
items: []*kyaml.RNode{
createTestNode(t, "v1", "Secret", "default", "other-secret"),
},
expectedError: "no items matched for selector",
},
{
name: "secret found by name",
selector: types.Selector{
ResId: resid.ResId{
Gvk: resid.Gvk{Kind: "Secret"}, Name: "my-secret",
},
},
items: []*kyaml.RNode{
createTestNode(t, "v1", "Secret", "default", "other-secret"),
createTestNode(t, "v1", "Secret", "default", "my-secret"),
},
expectedName: "my-secret",
},
{
name: "secret found by name and namespace",
selector: types.Selector{
ResId: resid.ResId{
Gvk: resid.Gvk{Kind: "Secret"},
Name: "my-secret",
Namespace: "my-ns",
},
},
items: []*kyaml.RNode{
createTestNode(t, "v1", "Secret", "default", "my-secret"),
createTestNode(t, "v1", "Secret", "my-ns", "my-secret"),
},
expectedName: "my-secret",
},
{
name: "secret found by label",
selector: types.Selector{
ResId: resid.ResId{Gvk: resid.Gvk{Kind: "Secret"}},
LabelSelector: "app=my-app",
},
items: []*kyaml.RNode{
func() *kyaml.RNode {
t.Helper()
node := createTestNode(t, "v1", "Secret", "default", "labeled-secret")
require.NoError(t, node.SetLabels(map[string]string{"app": "my-app"}))
return node
}(),
},
expectedName: "labeled-secret",
},
}

for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
secret, err := findAuthSecret(&tt.selector, tt.items)
if tt.expectedError != "" {
require.Error(t, err)
assert.Contains(t, err.Error(), tt.expectedError)
assert.Nil(t, secret)
} else {
require.NoError(t, err)
assert.NotNil(t, secret)
assert.Equal(t, tt.expectedName, secret.Name)
if tt.selector.Namespace != "" {
assert.Equal(t, tt.selector.Namespace, secret.Namespace)
}
}
})
}
}