Disconnect kafka consumers on sigterm

[nikossaravanos-workable]

No description provided.

[nikosd23]

Code review

Found 1 issue:

1. handleSigterm disconnects consumers fire-and-forget with no mechanism to hold the process alive until disconnects complete. Since handleSigterm is synchronous and returns immediately after starting the promises, Node.js can (and typically will) proceed to exit before any consumer.disconnect() call resolves — defeating the entire purpose of graceful shutdown. The existing disconnect() method uses await this.producer.disconnect() for exactly this reason.

orka/src/initializers/kafka/kafka.ts

Lines 181 to 192 in d699f67

	private handleSigterm() {
	logger.info('Received SIGTERM. Cancelling kafka consumers..');
	for (const [groupId, consumer] of this.consumers) {
	consumer.disconnect()
	.then(() => {
	logger.debug(`Consumer for kafka group ${groupId} disconnected.`);
	}).catch(e => {
	logger.error(`Consumer for kafka group ${groupId} failed to disconnect`, e);
	});
	}
	}

🤖 Generated with Claude Code

_{- If this code review was useful, please react with 👍. Otherwise, react with 👎.}

[nikossaravanos-workable]

The SIGTERM will not kill the process, the SIGKILL will after 30s

Code review

Found 1 issue:

1. handleSigterm disconnects consumers fire-and-forget with no mechanism to hold the process alive until disconnects complete. Since handleSigterm is synchronous and returns immediately after starting the promises, Node.js can (and typically will) proceed to exit before any consumer.disconnect() call resolves — defeating the entire purpose of graceful shutdown. The existing disconnect() method uses await this.producer.disconnect() for exactly this reason.

orka/src/initializers/kafka/kafka.ts

Lines 181 to 192 in d699f67

	private handleSigterm() {
	logger.info('Received SIGTERM. Cancelling kafka consumers..');
	for (const [groupId, consumer] of this.consumers) {
	consumer.disconnect()
	.then(() => {
	logger.debug(`Consumer for kafka group ${groupId} disconnected.`);
	}).catch(e => {
	logger.error(`Consumer for kafka group ${groupId} failed to disconnect`, e);
	});
	}
	}

🤖 Generated with Claude Code

• If this code review was useful, please react with 👍. Otherwise, react with 👎.