This repository was archived by the owner on Apr 24, 2025. It is now read-only.
20.0.0+work4 #37
Open
20.0.0+work4 #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: changed `AdUser` class to `User` that is actually present in the SDK and added the correct import line to the example Pull Request resolved: facebook#653 Test Plan: Imported from GitHub, without a `Test Plan:` line. README.md change only - no need test plan. Reviewed By: mengxuanzhangz Differential Revision: D49201605 Pulled By: stcheng fbshipit-source-id: 8f7a12146fe4cb2da5c31c629c3f2a49eba1d0f6
Summary: [BizSDK][Python] Update LICENSE and Header Reviewed By: mengxuanzhangz Differential Revision: D49200299 fbshipit-source-id: fc2625539360ef54f7a5db358002948b655ce5f3
Summary: There are small typos in: - facebook_business/adobjects/objectparser.py - facebook_business/api.py - facebook_business/docs_runner/doc_runner.py - facebook_business/test/integration_test_runner.py - facebook_business/video_uploader.py Fixes: - Should read `traversed` rather than `traverersed`. - Should read `transient` rather than `trasient`. - Should read `transient` rather than `tranient`. - Should read `reuse` rather than `resuse`. - Should read `return` rather than `retuen`. - Should read `prefix` rather than `preffix`. - Should read `immediately` rather than `immedidately`. Semi-automated pull request generated by https://github.com/timgates42/meticulous/blob/master/docs/NOTE.md Pull Request resolved: facebook#596 Reviewed By: mengxuanzhangz Differential Revision: D49286229 Pulled By: stcheng fbshipit-source-id: 53968efd114f5725fcf95056d0bc5bd37d41c91e
Summary: ignore-conflict-markers Reviewed By: stcheng Differential Revision: D49294255 fbshipit-source-id: f8715392f457f728f6cce55ff204b18817840643
Summary: ignore-conflict-markers Reviewed By: stcheng Differential Revision: D49642827 fbshipit-source-id: ba922064472a2f7c0aa53d000fca81e54a3396a6
Summary: [BizSDK][Python] Address Python Single Quote Escape Issue Add :escape_single_quote to python value. Bump the version to 18.0.2 for bug fixing. Reviewed By: mengxuanzhangz Differential Revision: D49841002 fbshipit-source-id: 91172d009671190ba449bb29ef698aaa52f0aa3f
Summary: Pull Request resolved: facebook#604 Reviewed By: mengxuanzhangz Differential Revision: D49881089 Pulled By: stcheng fbshipit-source-id: c43169f1924b9336352e029e952da91311f019de
Summary: - Convert for loop into list comprehension - Use `with` when opening file to ensure closure Pull Request resolved: facebook#601 Reviewed By: mengxuanzhangz Differential Revision: D49887278 Pulled By: stcheng fbshipit-source-id: 425497bbc1a43b9df044de100fee732e81196186
Summary: Pull Request resolved: facebook#602 Reviewed By: mengxuanzhangz Differential Revision: D49887267 Pulled By: stcheng fbshipit-source-id: 033619e69f7da1ddc4ef9bc5a59a4d879ebee724
Summary: Pull Request resolved: facebook#600 Reviewed By: mengxuanzhangz Differential Revision: D49887287 Pulled By: stcheng fbshipit-source-id: c8933acd73ac3c89c5c1d67aa840c2c436182c30
Summary: ignore-conflict-markers Reviewed By: mengxuanzhangz Differential Revision: D50280442 fbshipit-source-id: 8e546cc44e1c2e6bcfbbb82a290f46c289c2be0b
Summary: ignore-conflict-markers Reviewed By: stcheng Differential Revision: D50948022 fbshipit-source-id: fa4c1e519bea44ace49bd9d87149f30fcd757234
Summary: ignore-conflict-markers Reviewed By: stcheng Differential Revision: D51766614 fbshipit-source-id: 0670148c97a5cfc12bbebe81e2bc32d44c79969e
facebook#658) Summary: Fixed issue with not parsing <list<map correctly. I first noticed this when getting products underneath a product catalog. One of the items in the request consisted of a <list<list<map<string, string>>> value_type. This is currently not handled when this is parsed in the existing code. In the existing code, sub_type_value tries to access an index of the subtypes list that does not exist. I noticed some similar code in the function get_typed_value which I've used in the fix. Pull Request resolved: facebook#658 Reviewed By: mengxuanzhangz Differential Revision: D52914559 Pulled By: stcheng fbshipit-source-id: 2db42d1ebfd4aab3047da857ef79ade66b80c4ef
Summary: As mentioned in subject + removing Device Token and App User Id that are not part of app_data any more (App User Id to be moved to User Data in subsequent change for all languages) Reviewed By: stcheng Differential Revision: D51748022 fbshipit-source-id: fb523b057f453f57492cc61fc84ae8a065e8247e
Summary: This diff fixes a bug in the Python SDK for Facebook Business where the paging cursor was not properly checked for the existence of the 'next' key, which caused an infinite loop when there were no more pages to fetch. The code changes in the 'api.py' file of the SDK and the 'facebook_business/api.py' file of the codegen templates ensure that the 'after' cursor is only set if the 'next' key exists in the paging information. This should prevent the infinite loop and allow the SDK to properly handle paging in the API calls. Reviewed By: mengxuanzhangz Differential Revision: D53010767 fbshipit-source-id: 6588814b8fb48be213bedc4b7e304aeecdca0211
Summary: Add support of type KeyValue to Ruby, PHP, and Python. Reviewed By: mengxuanzhangz Differential Revision: D53016094 fbshipit-source-id: 50409b3f7f5f8df38853e266edf46e781c269a47
Summary: enum34; python_version Pull Request resolved: facebook#660 Reviewed By: mengxuanzhangz Differential Revision: D53016840 Pulled By: stcheng fbshipit-source-id: f454c643361235b73a6ced05b3a9ab3c3744f408
Summary: ignore-conflict-markers Reviewed By: stcheng Differential Revision: D53019897 fbshipit-source-id: cf65786e6b7e8768c59fb4c351e6ed072794ba70
Summary: Remove unused requirement which causes installation issue Reviewed By: mengxuanzhangz Differential Revision: D53321037 fbshipit-source-id: 2a6d33aa9cd4b778aa4be93b0eb632c10a8877e6
Summary: ignore-conflict-markers Reviewed By: stcheng Differential Revision: D54566006 fbshipit-source-id: 55087e609cf0604137c0bd9544ea9f7359ae6f0d
Summary: CAPI CTWA has been launched to 100% since November 2023, but is still not supported in our Meta Business SDK. This diff adds support for WhatsApp events on the Business SDK. It includes changes to the Event class to add a new field for the messaging channel, as well as changes to the User Data class to include new constants for the CTWA_CLID and PAGE_ID parameters. Reviewed By: stcheng Differential Revision: D54592282 fbshipit-source-id: 95e2e43718ab45e9a51bc3a89d8ee38239da7ff9
Summary: Pull Request resolved: facebook#636 Reviewed By: mengxuanzhangz Differential Revision: D54614769 Pulled By: stcheng fbshipit-source-id: d7f3b53a6a167ef993ab613e4931a401dfbc49e3
Summary: [BizSDK] Update Supported Destination Types Reviewed By: mengxuanzhangz Differential Revision: D54613743 fbshipit-source-id: 45a3e4bb007aa64944a823d6d19310d8f011b5fb
Summary:
In the current version nested objects are not handled correctly.
For example, we want to retrieve Ads for the campaign using only one request. With this fix, we'll be able to make requests like:
```
campaigns = account.get_campaigns(fields=['name,ads{id,name,status}'])
campaign = campaigns[0]
```
In this example nested Ads objects will be available as
```
campaign.get('ads')
```
Pull Request resolved: facebook#666
Reviewed By: mengxuanzhangz
Differential Revision: D54815751
Pulled By: stcheng
fbshipit-source-id: f23299bc168c33e485830ce500d8c8841cfbaf02
Summary: [BizSDK] Override Enum EnumAffectedChannels for All Languages Reviewed By: mengxuanzhangz Differential Revision: D54956307 fbshipit-source-id: 54bdd9067039aa8496966f8d563ad4e4127631ee
Summary: ignore-conflict-markers Reviewed By: stcheng Differential Revision: D54970845 fbshipit-source-id: c8ef2b1d9350912ec00403451598c315aa9f2dd4
Summary: ignore-conflict-markers Reviewed By: stcheng Differential Revision: D56033281 fbshipit-source-id: 9d9b948a023d9240558521b975ad6bea44caef14
Summary: ignore-conflict-markers Reviewed By: liliarizona Differential Revision: D58591195 fbshipit-source-id: c9b196dccae9cef6abc781579efed2221cb4d02e
jolancornevin
force-pushed
the
20.0.0+work4
branch
3 times, most recently
from
d9713f8 to
3e2afb9
Compare
jolancornevin
force-pushed
the
20.0.0+work4
branch
from
3e2afb9 to
92874e2
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://work4labs.atlassian.net/browse/PLAT-80