Skip to content

Twenty Twenty: Fix post meta wrapper not rendering when action hooks add content without default meta#11769

Open
shrivastavanolo wants to merge 1 commit intoWordPress:trunkfrom
shrivastavanolo:fix/twentytwenty-has-meta-hook
Open

Twenty Twenty: Fix post meta wrapper not rendering when action hooks add content without default meta#11769
shrivastavanolo wants to merge 1 commit intoWordPress:trunkfrom
shrivastavanolo:fix/twentytwenty-has-meta-hook

Conversation

@shrivastavanolo
Copy link
Copy Markdown

@shrivastavanolo shrivastavanolo commented May 8, 2026

twentytwenty_get_post_meta() uses a $has_meta flag to decide whether to return the meta wrapper HTML. This flag is only set to true when default meta fields (author, date, tags, etc.) are present. As a result, content added via thetwentytwenty_start_of_post_meta_list and twentytwenty_end_of_post_meta_list action hooks is silently discarded when no default meta exists — for example, on a post with no tags in the single-bottom location.

This fix checks whether the output buffer contains any content after stripping tags. The meta wrapper is now returned if either default meta or hook content is present.

Trac ticket: https://core.trac.wordpress.org/ticket/58223

Use of AI Tools

AI assistance: Yes
Tool(s): Claude
Model(s): Opus 4.6
Used for: Initial code skeleton and PR description; final implementation and tests were reviewed and edited by me.


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 8, 2026

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props shreya0shrivastava.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 8, 2026

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant