Follow up fixes to r62282#11735
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| updates: | ||
| # Check for updates to GitHub Actions. | ||
| - package-ecosystem: "github-actions" |
| - "*" | ||
|
|
||
| # Check for updates to Composer packages. | ||
| - package-ecosystem: "composer" |
| - "composer/ca-bundle" | ||
|
|
||
| # Monitor some npm dependencies for updates in groups. | ||
| - package-ecosystem: "npm" |
| - "underscore" | ||
|
|
||
| # Monitor npm dependencies within default themes. | ||
| - package-ecosystem: "npm" |
| - "**browserslist*" | ||
| - "*css*" | ||
|
|
||
| - package-ecosystem: "npm" |
| - "**browserslist*" | ||
| - "*css*" | ||
|
|
||
| - package-ecosystem: "npm" |
| - "minimist" | ||
| - "npm-run-all" | ||
|
|
||
| - package-ecosystem: "npm" |
| - "concurrently" | ||
| - "@wordpress/scripts" | ||
|
|
||
| - package-ecosystem: "npm" |
| ( applePattern, appleOSLabel ) => { | ||
| if ( ( new RegExp( applePattern ) ).test( navigator.userAgent ) ) { | ||
| document.querySelector( '#wp-admin-bar-command-palette .ab-label kbd' ).textContent = appleOSLabel; | ||
| if ( ! ( new RegExp( applePattern, 'i' ) ).test( navigator.userAgent ) ) { |
There was a problem hiding this comment.
Good catch. This matches the case insensitivity in PHP:
preg_match( "/{$apple_pattern}/i", $_SERVER['HTTP_USER_AGENT'] ?? '' );
westonruter
left a comment
westonruter
left a comment
There was a problem hiding this comment.
The changes to src/wp-includes/admin-bar.php look good to me.
The changes in .github I will defer to your expertise.
3 participants
Follow up to r62282.
TypeErrorif the admin bar element has been moved or manipulated in some way.Trac ticket: Core-65121.
Use of AI Tools
AI assistance: Yes
Tool(s): Claude
Model(s): Opus 4.7
Used for: Used Claude to analyze the previous changeset to try and find potential issues. Validated them before fixing here in the PR.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.