Skip to content

Add aria-label to post links #11350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Kurikania wants to merge 1 commit into from
Closed

Add aria-label to post links #11350

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion src/wp-admin/includes/class-wp-posts-list-table.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1136,10 +1136,22 @@

$title = _draft_or_post_title();

$post_type_object = get_post_type_object( $post->post_type );

if ( has_post_parent($post) ) {
$label = esc_attr( sprintf( __( 'Subpage %s (Edit)' ), $title) );
$parent = get_post( $post->post_parent );
$parent_name = apply_filters( 'the_title', $parent->post_title, $parent->ID );
} else {
$label = esc_attr( sprintf( __( '%s %s (Edit)' ), $post_type_object->labels->singular_name ,$title) ); $title;
}

Check failure on line 1147 in src/wp-admin/includes/class-wp-posts-list-table.php

View workflow job for this annotation

GitHub Actions / Coding standards / PHP checks 

Expected 1 spaces before closing parenthesis; 0 found

Check failure on line 1147 in src/wp-admin/includes/class-wp-posts-list-table.php

View workflow job for this annotation

GitHub Actions / Coding standards / PHP checks 

Expected 1 spaces after opening parenthesis; 0 found

Check failure on line 1148 in src/wp-admin/includes/class-wp-posts-list-table.php

View workflow job for this annotation

GitHub Actions / Coding standards / PHP checks 

Expected 1 spaces before closing parenthesis; 0 found

if ( $can_edit_post && 'trash' !== $post->post_status ) {
printf(
'<a class="row-title" href="%s">%s%s</a>',
'<a class="row-title" aria-label="%s" href="%s">%s%s</a>',

Check failure on line 1152 in src/wp-admin/includes/class-wp-posts-list-table.php

View workflow job for this annotation

GitHub Actions / Coding standards / PHP checks 

Each PHP statement must be on a line by itself

Check failure on line 1152 in src/wp-admin/includes/class-wp-posts-list-table.php

View workflow job for this annotation

GitHub Actions / Coding standards / PHP checks 

Expected 1 spaces before closing parenthesis; 0 found

Check failure on line 1152 in src/wp-admin/includes/class-wp-posts-list-table.php

View workflow job for this annotation

GitHub Actions / Coding standards / PHP checks 

No space found after comma in argument list

Check failure on line 1152 in src/wp-admin/includes/class-wp-posts-list-table.php

View workflow job for this annotation

GitHub Actions / Coding standards / PHP checks 

Space found before comma in argument list

Check failure on line 1152 in src/wp-admin/includes/class-wp-posts-list-table.php

View workflow job for this annotation

GitHub Actions / Coding standards / PHP checks 

Multiple placeholders in translatable strings should be ordered. Expected "%1$s, %2$s", but got "%s, %s" in '%s %s (Edit)'.
$label,
get_edit_post_link( $post->ID ),

Check failure on line 1154 in src/wp-admin/includes/class-wp-posts-list-table.php

View workflow job for this annotation

GitHub Actions / Coding standards / PHP checks 

Functions must not contain multiple empty lines in a row; found 2 empty lines

Check failure on line 1154 in src/wp-admin/includes/class-wp-posts-list-table.php

View workflow job for this annotation

GitHub Actions / Coding standards / PHP checks 

Whitespace found at end of line
$pad,
$title
);
Expand Down
Loading