Improve validation and permission checks for WP_HTTP_Polling_Sync_Server#11296
Improve validation and permission checks for WP_HTTP_Polling_Sync_Server#11296chriszarate wants to merge 2 commits intoWordPress:trunkfrom
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
| 'methods' => array( WP_REST_Server::CREATABLE ), | ||
| 'callback' => array( $this, 'handle_request' ), | ||
| 'permission_callback' => array( $this, 'check_permissions' ), | ||
| 'validate_callback' => array( $this, 'validate_request' ), |
There was a problem hiding this comment.
The presence of a validate_callback will prevent the input from being validated against the JSON Schema for the args, unfortunately. This is something which was pointed out to me by @deepaklalwani97 in #10966. See #10966 (comment).
I believe you'll need to explicitly validate against the schema in the validate_callback, as seen in that PR.
There was a problem hiding this comment.
Or maybe this is different since the validate_callback is added at the endpoint level instead of at the arg level? In any case, I wanted to flag it as something to be verified.
Harden
WP_HTTP_Polling_Sync_Serverendpoints to add additional validation and permission checks.Props @peterwilsoncc for contributions
Trac ticket: https://core.trac.wordpress.org/ticket/64890