Make RTC opt-in / off-by-default#11289
Conversation
Can you link to this conversation? |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Apologies, description has been updated. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
peterwilsoncc
left a comment
There was a problem hiding this comment.
I've added a couple of notes inline. I'm doing some manual testing now.
src/wp-includes/collaboration.php
Outdated
| * | ||
| * @return bool True if real-time collaboration is enabled, false otherwise. | ||
| */ | ||
| function wp_is_collaboration_enabled() { |
There was a problem hiding this comment.
Let's keep the addition of this function for the table PR and just use get_option() for now.
How we handle availability might need some fine tuning.
aaronjorbin
left a comment
There was a problem hiding this comment.
I don't love all the churn from renaming the option especially with RC1 less than 24 hours away.
I also want to express that shipping a new feature that is disabled by default feels like it violates the clean, lean, and mean philosophy and isn't something that I think WordPress should ever do.
Co-Authored-By: jorbin <jorbin@git.wordpress.org>
I think the diff looks a little higher churn than it is for two reasons:
Without those changes the PR is about |
peterwilsoncc
left a comment
There was a problem hiding this comment.
I'm happy with this, @chriszarate are you happy with the changes I pushed?
| global $pagenow; | ||
|
|
||
| if ( ! get_option( 'wp_enable_real_time_collaboration' ) ) { | ||
| if ( ! (bool) get_option( 'wp_collaboration_enabled' ) ) { |
There was a problem hiding this comment.
is the (bool) necessary since this is doing a truthy/falsy check anyway?
| self::$post_id = $factory->post->create( array( 'post_author' => self::$editor_id ) ); | ||
|
|
||
| // Enable option in setUpBeforeClass to ensure REST routes are registered. | ||
| update_option( 'wp_collaboration_enabled', 1 ); |
There was a problem hiding this comment.
This feels redundant with it also being done in set_up
There was a problem hiding this comment.
It is needed for the reason noted in the comment.
Yes, they look fine. Thank you. I agree with @aaronjorbin that the |
|
Thank you. I'm going to commit this. |
See: https://wordpress.slack.com/archives/C07NVJ51X6K/p1773850504196589. We are intentionally changing the option name so that it will be off-by-default for everyone, including those that installed a beta release where the feature was on-by-default. Developed in: #11289. Fixes #64845. Props czarate, peterwilsoncc, jorbin. git-svn-id: https://develop.svn.wordpress.org/trunk@62058 602fd350-edb4-49c9-b593-d223f7449a82
See: https://wordpress.slack.com/archives/C07NVJ51X6K/p1773850504196589. We are intentionally changing the option name so that it will be off-by-default for everyone, including those that installed a beta release where the feature was on-by-default. Developed in: WordPress/wordpress-develop#11289. Fixes #64845. Props czarate, peterwilsoncc, jorbin. Built from https://develop.svn.wordpress.org/trunk@62058 git-svn-id: http://core.svn.wordpress.org/trunk@61340 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Per the comment in Core Slack, we are moving the real-time collaboration feature to opt-in / off-by-default for 7.0 RC 1. Thank you to everyone who provided feedback during the testing period.
Note that we are intentionally changing the option name so that it will be off-by-default for everyone, including those that installed a beta release where the feature was on-by-default.
Trac ticket: https://core.trac.wordpress.org/ticket/64845