Admin reskin: fix pressed state button style#11282
Admin reskin: fix pressed state button style#11282t-hamano wants to merge 6 commits intoWordPress:trunkfrom
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
joedolson
left a comment
There was a problem hiding this comment.
The darker background with the foreground color is creating a color contrast that is below requirements.
This will need more work. A couple possibilities would be darkening the text color; or using a lighter background with a darker shadow. The box shadow largely doesn't interfere with the text color, so if we increased the dependence on that for differentiation, we should be able to maintain color contrast.
d91abc4 to
0f58c86
Compare
joedolson
left a comment
There was a problem hiding this comment.
Color contrast works for me, now. If the design system comes up with something better later, we can switch; but this resolves the issue.
|
I have no idea why that merge happened the way it did...how weird. |






Trac ticket: https://core.trac.wordpress.org/ticket/64856
Button
Default state
Focused state
Button Group
Default state
Focused state
Use of AI Tools
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.