Skip to content

Admin reskin: fix pressed state button style#11282

Closed
t-hamano wants to merge 6 commits intoWordPress:trunkfrom
t-hamano:64856-button-pressed-state
Closed

Admin reskin: fix pressed state button style#11282
t-hamano wants to merge 6 commits intoWordPress:trunkfrom
t-hamano:64856-button-pressed-state

Conversation

@t-hamano
Copy link
Contributor

@t-hamano t-hamano commented Mar 18, 2026

Trac ticket: https://core.trac.wordpress.org/ticket/64856

Button

Default state

Before After
image image
image image

Focused state

Before After
image image
image image

Button Group

Default state

Before After
image image
image image

Focused state

Before After
image image
image image

Use of AI Tools


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@github-actions
Copy link

github-actions bot commented Mar 18, 2026

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props wildworks, joedolson, mukesh27, shailu25.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions
Copy link

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@shail-mehta
Copy link
Member

The contrast between the default and selected states of the secondary variation buttons is now clearly identifiable. ✅

Before After
before-patch after-patch

Button Variations:

Before After
before-patch after-patch

@joedolson joedolson self-requested a review March 22, 2026 20:32
Copy link
Contributor

@joedolson joedolson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The darker background with the foreground color is creating a color contrast that is below requirements.

This will need more work. A couple possibilities would be darkening the text color; or using a lighter background with a darker shadow. The box shadow largely doesn't interfere with the text color, so if we increased the dependence on that for differentiation, we should be able to maintain color contrast.

@t-hamano t-hamano force-pushed the 64856-button-pressed-state branch from d91abc4 to 0f58c86 Compare March 23, 2026 01:56
@t-hamano
Copy link
Contributor Author

Thanks for the feedback!

A couple possibilities would be darkening the text color; or using a lighter background with a darker shadow.

I tried to improve the contrast:

image image

@joedolson joedolson self-requested a review March 24, 2026 17:17
Copy link
Contributor

@joedolson joedolson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Color contrast works for me, now. If the design system comes up with something better later, we can switch; but this resolves the issue.

@joedolson
Copy link
Contributor

I have no idea why that merge happened the way it did...how weird.

@github-actions
Copy link

A commit was made that fixes the Trac ticket referenced in the description of this pull request.

SVN changeset: 62106
GitHub commit: ad285ee

This PR will be closed, but please confirm the accuracy of this and reopen if there is more work to be done.

@github-actions github-actions bot closed this Mar 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants