Backport real-time collaboration peer limits from Gutenberg #75381#11266
Open
pkevan wants to merge 3 commits intoWordPress:trunkfrom
Open
Backport real-time collaboration peer limits from Gutenberg #75381#11266pkevan wants to merge 3 commits intoWordPress:trunkfrom
pkevan wants to merge 3 commits intoWordPress:trunkfrom
Conversation
Add per-room and per-user limits to enforce concurrent peer capacity during real-time collaboration. When a room reaches capacity (default: 2 peers), new users receive HTTP 429. Users can open multiple tabs up to a per-user limit (default: 2). Limits are configurable via filters: - real_time_collaboration_max_peers_per_room - real_time_collaboration_max_clients_per_user Includes comprehensive test coverage for capacity enforcement, filter overrides, and edge cases (existing users, disconnects, collection rooms). PHP server-side backport only. Client-side polling manager changes ship via Gutenberg @wordpress/sync package updates. Fixes WordPress#11120
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
Tests for update counting and stale compaction use 4 client IDs from the same user, which now exceeds the DEFAULT_MAX_CLIENTS_PER_USER limit of 2 introduced in the peer limits backport.
pkevan
force-pushed
the
pkevan/backport-gb-75381
branch
from
fb71fb0 to
3ab4056
Compare
The empty() check was replacing null awareness (disconnect signal) with default data, causing the peer limit disconnect test to fail.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Backport of Gutenberg PR #75381: Add per-room and per-user limits to enforce concurrent peer capacity during real-time collaboration. When a room reaches capacity (default: 2 peers), new users receive HTTP 429. Users can open multiple tabs up to a per-user limit (default: 2).
Two new filters allow customization:
real_time_collaboration_max_peers_per_roomreal_time_collaboration_max_clients_per_userIncludes comprehensive test coverage for capacity enforcement, filter overrides, and edge cases.
Note: Client-side polling manager changes ship via Gutenberg
@wordpress/syncpackage updates. This backport covers PHP server-side only.Fixes #11120