Skip to content

Icons: Add label search support to WP_Icons_Registry #11235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
t-hamano wants to merge 2 commits into
base: trunk
Choose a base branch
from
Draft

Icons: Add label search support to WP_Icons_Registry #11235

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cfdd6c3
Icons: Add label search support to WP_Icons_Registry
t-hamano Mar 12, 2026
5d0cff5
Merge branch 'trunk' into 64847-search-icon-labels
t-hamano Mar 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/wp-includes/class-wp-icons-registry.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,7 +271,10 @@ public function get_registered_icons( $search = '' ) {
$icons = array();

foreach ( $this->registered_icons as $icon ) {
if ( ! empty( $search ) && false === stripos( $icon['name'], $search ) ) {
if ( ! empty( $search )
&& false === stripos( $icon['name'], $search )
&& false === stripos( $icon['label'] ?? '', $search )
) {
continue;
}

Expand Down
21 changes: 21 additions & 0 deletions tests/phpunit/tests/icons/wpRestIconsController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -296,6 +296,27 @@ public function test_get_items_search_filters_results() {
$this->assertContains( 'core/arrow-left', $icon_names, 'Search results should include core/arrow-left icon' );
}

/**
* Test that GET /wp/v2/icons/?search= searches icon labels too.
*
* @ticket 64847
*
* @covers ::get_items
*/
public function test_get_items_search_includes_label() {
wp_set_current_user( self::$editor_id );

$request = new WP_REST_Request( 'GET', '/wp/v2/icons' );

// The '@' character is only found in the *label* for core/at-symbol
$request->set_param( 'search', '@' );
$response = rest_get_server()->dispatch( $request );
$data = $response->get_data();

$this->assertSame( 200, $response->get_status() );
$this->assertEquals( array( 'core/at-symbol' ), array_column( $data, 'name' ) );
}

/**
* Test that search is case-insensitive.
*
Expand Down
Loading