Skip to content

Enable RTC by default, redo.#11161

Closed
peterwilsoncc wants to merge 7 commits intoWordPress:trunkfrom
peterwilsoncc:fix/64622-enable-rtc-by-default
Closed

Enable RTC by default, redo.#11161
peterwilsoncc wants to merge 7 commits intoWordPress:trunkfrom
peterwilsoncc:fix/64622-enable-rtc-by-default

Conversation

@peterwilsoncc
Copy link
Contributor

@peterwilsoncc peterwilsoncc commented Mar 4, 2026

Enable Real Time Collaboration by default.

Trac ticket: https://core.trac.wordpress.org/ticket/64622

  • Reverts option name change
  • Adds filter so default value of the option is true.
  • Re-applies test changes from original commit to account for reversal of default. (Note: I've removed the remove_filter() calls as they are reset between tests in the test suites default tearDown method.)

Use of AI Tools

None.


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@peterwilsoncc peterwilsoncc marked this pull request as ready for review March 4, 2026 21:56
@github-actions
Copy link

github-actions bot commented Mar 4, 2026

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props peterwilsoncc, czarate, sergeybiryukov.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@peterwilsoncc peterwilsoncc changed the title Fix/64622 enable rtc by default Enable RTC by default, redo. Mar 4, 2026
@github-actions
Copy link

github-actions bot commented Mar 4, 2026

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Comment on lines +566 to +568

// 7.0.0
'wp_enable_real_time_collaboration' => 1,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this necessary / useful if we are separately filtering the default value?

Copy link
Contributor Author

@peterwilsoncc peterwilsoncc Mar 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The practice has been to add the default options regardless, see link_manager_enabled which uses a similar filter:

Edit to remove dumb example: all the other options that default to a falsey value are included here even though they're not strictly required.

@peterwilsoncc
Copy link
Contributor Author

@chriszarate Actually ready for review now... I'd missed that the filter in the tests preflighting the option to off needed to use __return_zero for it to actually work due to this code:

if ( false !== $pre ) {
return $pre;
}

@peterwilsoncc peterwilsoncc added props-bot Adding this label triggers the Props Bot workflow for a PR. labels Mar 5, 2026
@github-actions github-actions bot removed the props-bot Adding this label triggers the Props Bot workflow for a PR. label Mar 5, 2026
pento pushed a commit that referenced this pull request Mar 5, 2026
This reverts the real time collaboration option name back to `wp_enable_real_time_collaboration` to avoid the need to turn on a checkbox in order to turn off the feature. This is to reduce the cognitive load on both users and developers of an on is off paradigm.

To ensure Real Time Collaboration is enabled prior to the upgrade routine running on multi-site installs, the option default is filtered on the `default_option_wp_enable_real_time_collaboration` hook to enable the option by default.

Developed in: #11161
Follow up to r61828.

Props peterwilsoncc, czarate, sergeybiryukov.
Fixes #64622.


git-svn-id: https://develop.svn.wordpress.org/trunk@61833 602fd350-edb4-49c9-b593-d223f7449a82
@github-actions
Copy link

github-actions bot commented Mar 5, 2026

A commit was made that fixes the Trac ticket referenced in the description of this pull request.

SVN changeset: 61833
GitHub commit: 1f333db

This PR will be closed, but please confirm the accuracy of this and reopen if there is more work to be done.

@github-actions github-actions bot closed this Mar 5, 2026
@peterwilsoncc peterwilsoncc deleted the fix/64622-enable-rtc-by-default branch March 5, 2026 00:28
markjaquith pushed a commit to markjaquith/WordPress that referenced this pull request Mar 5, 2026
This reverts the real time collaboration option name back to `wp_enable_real_time_collaboration` to avoid the need to turn on a checkbox in order to turn off the feature. This is to reduce the cognitive load on both users and developers of an on is off paradigm.

To ensure Real Time Collaboration is enabled prior to the upgrade routine running on multi-site installs, the option default is filtered on the `default_option_wp_enable_real_time_collaboration` hook to enable the option by default.

Developed in: WordPress/wordpress-develop#11161
Follow up to r61828.

Props peterwilsoncc, czarate, sergeybiryukov.
Fixes #64622.

Built from https://develop.svn.wordpress.org/trunk@61833


git-svn-id: http://core.svn.wordpress.org/trunk@61120 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants