Enable RTC by default, redo.#11161
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
|
|
||
| // 7.0.0 | ||
| 'wp_enable_real_time_collaboration' => 1, |
There was a problem hiding this comment.
Is this necessary / useful if we are separately filtering the default value?
There was a problem hiding this comment.
The practice has been to add the default options regardless, see link_manager_enabled which uses a similar filter:
Edit to remove dumb example: all the other options that default to a falsey value are included here even though they're not strictly required.
|
@chriszarate Actually ready for review now... I'd missed that the filter in the tests preflighting the option to off needed to use wordpress-develop/src/wp-includes/option.php Lines 152 to 154 in a9fbc1b |
This reverts the real time collaboration option name back to `wp_enable_real_time_collaboration` to avoid the need to turn on a checkbox in order to turn off the feature. This is to reduce the cognitive load on both users and developers of an on is off paradigm. To ensure Real Time Collaboration is enabled prior to the upgrade routine running on multi-site installs, the option default is filtered on the `default_option_wp_enable_real_time_collaboration` hook to enable the option by default. Developed in: #11161 Follow up to r61828. Props peterwilsoncc, czarate, sergeybiryukov. Fixes #64622. git-svn-id: https://develop.svn.wordpress.org/trunk@61833 602fd350-edb4-49c9-b593-d223f7449a82
This reverts the real time collaboration option name back to `wp_enable_real_time_collaboration` to avoid the need to turn on a checkbox in order to turn off the feature. This is to reduce the cognitive load on both users and developers of an on is off paradigm. To ensure Real Time Collaboration is enabled prior to the upgrade routine running on multi-site installs, the option default is filtered on the `default_option_wp_enable_real_time_collaboration` hook to enable the option by default. Developed in: WordPress/wordpress-develop#11161 Follow up to r61828. Props peterwilsoncc, czarate, sergeybiryukov. Fixes #64622. Built from https://develop.svn.wordpress.org/trunk@61833 git-svn-id: http://core.svn.wordpress.org/trunk@61120 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Enable Real Time Collaboration by default.
Trac ticket: https://core.trac.wordpress.org/ticket/64622
remove_filter()calls as they are reset between tests in the test suites default tearDown method.)Use of AI Tools
None.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.