Skip to content

Adjust grunt clean to account for recent build script changes#11036

Closed
desrosj wants to merge 11 commits intoWordPress:trunkfrom
desrosj:add/grunt-clean-gutenberg
Closed

Adjust grunt clean to account for recent build script changes#11036
desrosj wants to merge 11 commits intoWordPress:trunkfrom
desrosj:add/grunt-clean-gutenberg

Conversation

@desrosj
Copy link
Member

@desrosj desrosj commented Feb 25, 2026

This updates the grunt clean task to clean up properly after the changes in r61438.

Trac ticket: Core-64716.

Use of AI Tools

Claude Code was used to confirm the changes were accurate.


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@desrosj desrosj self-assigned this Feb 25, 2026
@github-actions
Copy link

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@desrosj desrosj marked this pull request as ready for review February 25, 2026 05:41
@github-actions
Copy link

github-actions bot commented Feb 25, 2026

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props desrosj, jorbin.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@desrosj desrosj requested a review from adamsilverstein March 18, 2026 18:18
@desrosj
Copy link
Member Author

desrosj commented Mar 18, 2026

@adamsilverstein I haven't gotten to test after refreshing just yet. But I added you as a reviewer because your work on #11281 will be a good way to test this.

To test, run npm run build:dev in your PR's branch, then run npm run grunt clean -- --dev with this one cloned. Repeat for npm run build and npm run grunt clean.

@desrosj
Copy link
Member Author

desrosj commented Mar 18, 2026

This is testing well for me. Here's how I tested:

  • I cloned https://github.com/WordPress/wordpress.
  • Copied the contents of that clone into build in my wordpress-develop fork.
  • Ran diff -rq --exclude=".git" /path/to/fork/wordpress-develop/build /path/to/build/repo/WordPress/wordpress/
  • Observer no differences.
  • Run npm run grunt clean && npm run build
  • Rerun the diff command.

You should see something like this:

Only in /path/to/build/server/checkoutWordPress/wordpress/wp-includes/build/pages: connectors
Only in /path/to/build/server/checkoutWordPress/wordpress/wp-includes/build/pages: site-editor
Only in /path/to/build/server/checkoutWordPress/wordpress/wp-includes/build/pages: site-editor-v2
Only in /path/to/build/server/checkoutWordPress/wordpress/wp-includes/build/routes/font-list: package.json
Only in /path/to/build/server/checkoutWordPress/wordpress/wp-includes/build/routes/fonts-home: package.json
Only in /path/to/build/server/checkoutWordPress/wordpress/wp-includes/build/routes/home: package.json
Only in /path/to/build/server/checkoutWordPress/wordpress/wp-includes/build/routes: index.php
Only in /path/to/build/server/checkoutWordPress/wordpress/wp-includes/build/routes/navigation: package.json
Only in /path/to/build/server/checkoutWordPress/wordpress/wp-includes/build/routes/navigation-edit: package.json
Only in /path/to/build/server/checkoutWordPress/wordpress/wp-includes/build/routes/navigation-list: package.json
Only in /path/to/build/server/checkoutWordPress/wordpress/wp-includes/build/routes/pattern: package.json
Only in /path/to/build/server/checkoutWordPress/wordpress/wp-includes/build/routes/pattern-list: package.json
Only in /path/to/build/server/checkoutWordPress/wordpress/wp-includes/build/routes/post: package.json
Only in /path/to/build/server/checkoutWordPress/wordpress/wp-includes/build/routes/post-edit: package.json
Only in /path/to/build/server/checkoutWordPress/wordpress/wp-includes/build/routes/post-list: package.json
Only in /path/to/build/server/checkoutWordPress/wordpress/wp-includes/build/routes/post-new: package.json
Only in /path/to/build/server/checkoutWordPress/wordpress/wp-includes/build/routes/styles: package.json
Only in /path/to/build/server/checkoutWordPress/wordpress/wp-includes/build/routes/template: package.json
Only in /path/to/build/server/checkoutWordPress/wordpress/wp-includes/build/routes/template-list: package.json
Only in /path/to/build/server/checkoutWordPress/wordpress/wp-includes/build/routes/template-part: package.json
Only in /path/to/build/server/checkoutWordPress/wordpress/wp-includes/build/routes/template-part-list: package.json
Only in /path/to/build/server/checkoutWordPress/wordpress/wp-includes/icons/library: resize-corner-n-e.svg

desrosj and others added 4 commits March 18, 2026 20:50
Co-authored-by: aaronjorbin <jorbin@git.wordpress.org>

Co-authored-by: Aaron Jorbin <aaronjorbin@users.noreply.github.com>
@github-actions
Copy link

A commit was made that fixes the Trac ticket referenced in the description of this pull request.

SVN changeset: 62051
GitHub commit: dc20352

This PR will be closed, but please confirm the accuracy of this and reopen if there is more work to be done.

@github-actions github-actions bot closed this Mar 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants