Site Editor > Templates: move config to the server#76622
Merged
Conversation
oandregal
changed the title
This was referenced Mar 18, 2026
oandregal
added
[Type] Enhancement
|
Size Change: +90 B (0%) Total Size: 7.66 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 015e3dd. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/23534338310
|
oandregal
force-pushed
the
try/view-config-server
branch
from
d8724eb to
05d6187
Compare
oandregal
force-pushed
the
update/view-config-templates
branch
4 times, most recently
from
da48b75 to
9cd9fa5
Compare
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Member
Author
|
There are 4 template screens and 3 sidebars for templates — accounting for the "site editor extensibility" and "template activation" experiments. This PR only migrates the main screen. Additionally, the main screen (no experiments enabled) contents for sidebar and stage are called "legacy", so it's all a bit disorientating. Noted the other ones as follow-ups at #76544 |
oandregal
commented
Mar 20, 2026
Comment on lines
+41
to
+61
| const authorSourceMap = useSelect( ( select ) => { | ||
| const templates = select( coreStore ).getEntityRecords( | ||
| 'postType', | ||
| TEMPLATE_POST_TYPE, | ||
| { per_page: -1 } | ||
| ); | ||
| }, [ records ] ); | ||
| if ( ! templates ) { | ||
| return {}; | ||
| } | ||
| const map = {}; | ||
| for ( const template of templates ) { | ||
| if ( | ||
| template.author_text && | ||
| template.original_source && | ||
| ! map[ template.author_text ] | ||
| ) { | ||
| map[ template.author_text ] = template.original_source; | ||
| } | ||
| } | ||
| return map; | ||
| }, [] ); |
Member
Author
There was a problem hiding this comment.
Like the pages PR, this PR adds the icons client-side. The situation here is different, in that the icon is derived from the source of the view (is the template from an user? from a theme? from a plugin?).
oandregal
commented
Mar 20, 2026
Comment on lines
+27
to
+30
| user: commentAuthorAvatar, | ||
| theme: layout, | ||
| plugin: pluginIcon, | ||
| site: globe, |
Member
Author
There was a problem hiding this comment.
This is using the same icons as useAddedBy hook.
oandregal
commented
Mar 20, 2026
Comment on lines
+678
to
+765
| /** | ||
| * Returns the original source of a template. | ||
| * | ||
| * @param WP_Block_Template $template_object Template instance. | ||
| * @return string The original source ('theme', 'plugin', 'site', or 'user'). | ||
| */ | ||
| private static function get_template_original_source( $template_object ) { | ||
| if ( 'wp_template' === $template_object->type || 'wp_template_part' === $template_object->type ) { | ||
| if ( $template_object->has_theme_file && | ||
| ( 'theme' === $template_object->origin || ( | ||
| empty( $template_object->origin ) && in_array( | ||
| $template_object->source, | ||
| array( | ||
| 'theme', | ||
| 'custom', | ||
| ), | ||
| true | ||
| ) ) | ||
| ) | ||
| ) { | ||
| return 'theme'; | ||
| } | ||
|
|
||
| if ( 'plugin' === $template_object->origin ) { | ||
| return 'plugin'; | ||
| } | ||
|
|
||
| if ( empty( $template_object->has_theme_file ) && 'custom' === $template_object->source && empty( $template_object->author ) ) { | ||
| return 'site'; | ||
| } | ||
| } | ||
|
|
||
| return 'user'; | ||
| } | ||
|
|
||
| /** | ||
| * Returns a human readable text for the author of a template. | ||
| * | ||
| * @param WP_Block_Template $template_object Template instance. | ||
| * @param string $original_source The original source of the template. | ||
| * @return string Human readable text for the author. | ||
| */ | ||
| private static function get_template_author_text( $template_object, $original_source ) { | ||
| switch ( $original_source ) { | ||
| case 'theme': | ||
| $theme_name = wp_get_theme( $template_object->theme )->get( 'Name' ); | ||
| return empty( $theme_name ) ? $template_object->theme : $theme_name; | ||
| case 'plugin': | ||
| if ( ! function_exists( 'get_plugins' ) ) { | ||
| require_once ABSPATH . 'wp-admin/includes/plugin.php'; | ||
| } | ||
| if ( isset( $template_object->plugin ) ) { | ||
| $plugins = wp_get_active_and_valid_plugins(); | ||
|
|
||
| foreach ( $plugins as $plugin_file ) { | ||
| $plugin_basename = plugin_basename( $plugin_file ); | ||
| list( $plugin_slug, ) = explode( '/', $plugin_basename ); | ||
|
|
||
| if ( $plugin_slug === $template_object->plugin ) { | ||
| $plugin_data = get_plugin_data( $plugin_file ); | ||
|
|
||
| if ( ! empty( $plugin_data['Name'] ) ) { | ||
| return $plugin_data['Name']; | ||
| } | ||
|
|
||
| break; | ||
| } | ||
| } | ||
| } | ||
|
|
||
| $plugins = get_plugins(); | ||
| $plugin_basename = plugin_basename( sanitize_text_field( $template_object->theme . '.php' ) ); | ||
| if ( isset( $plugins[ $plugin_basename ] ) && isset( $plugins[ $plugin_basename ]['Name'] ) ) { | ||
| return $plugins[ $plugin_basename ]['Name']; | ||
| } | ||
| return $template_object->plugin ?? $template_object->theme; | ||
| case 'site': | ||
| return get_bloginfo( 'name' ); | ||
| case 'user': | ||
| $author = get_user_by( 'id', $template_object->author ); | ||
| if ( ! $author ) { | ||
| return __( 'Unknown author', 'gutenberg' ); | ||
| } | ||
| return $author->get( 'display_name' ); | ||
| } | ||
|
|
||
| return ''; | ||
| } |
Member
Author
There was a problem hiding this comment.
These utilities have been copied from the existing templates REST endpoint. It seems this info may need a better way to be encapsulated.
Contributor
There was a problem hiding this comment.
I believe it would be fine to make get_wp_templates_author_text_field function private and since it's static, call it to get the value without duplicating anything.
Member
Author
There was a problem hiding this comment.
I'm not comfortable making them public since I'm not sure this is the best API.
ntsekouras
reviewed
Mar 23, 2026
ntsekouras
reviewed
Mar 23, 2026
oandregal
force-pushed
the
update/view-config-templates
branch
from
9ca365a to
d4cf7db
Compare
oandregal
added a commit
to oandregal/wordpress-develop
that referenced
this pull request
Mar 25, 2026
adamsilverstein
pushed a commit
that referenced
this pull request
Mar 26, 2026
Co-authored-by: oandregal <oandregal@git.wordpress.org> Co-authored-by: ntsekouras <ntsekouras@git.wordpress.org>
adamsilverstein
pushed a commit
that referenced
this pull request
Mar 31, 2026
Co-authored-by: oandregal <oandregal@git.wordpress.org> Co-authored-by: ntsekouras <ntsekouras@git.wordpress.org>
adamsilverstein
pushed a commit
that referenced
this pull request
Apr 7, 2026
Co-authored-by: oandregal <oandregal@git.wordpress.org> Co-authored-by: ntsekouras <ntsekouras@git.wordpress.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #76544
Backported at WordPress/wordpress-develop#11272
What?
Moves the template view configuration (default view, layouts, and view list) from client-side JavaScript (page-templates/view-utils.js) to the server-side REST endpoint (/wp/v2/view-config), continuing the pattern established for pages in #76573
Why?
See #76544
This is part of an ongoing effort to centralize view configuration on the server so that it can be managed, extended, and overridden consistently across entity types.
How?
useViewConfighook.Testing Instructions
Test the Site Editor > Templates screen.
Use of AI Tools
This PR was authored with Claude Code (Claude Opus 4.6).