Performance: Consolidate redundant APIs into getCurrentTheme #804
+63
−137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The theme.json modal and the metadata modal reference their own endpoints to retrieve data that the
getCurrentThemeselector can't retrieve, but this is redundant:getCurrentTheme+fetchThemeJsongetCurrentTheme+fetchReadmeDataIt would make more sense to include the additional data in the
getCurrentThemeresponse.Another reason for submitting this PR is to enable future updates to theme templates and metadata without a browser reload.
If all data is integrated into the default WordPress store,
invalidateResolutionwill allow the selector resolution cache to be refreshed without a browser reload.