Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
1 change: 1 addition & 0 deletions phpstan.neon
Original file line number Diff line number Diff line change
Expand Up @@ -19,3 +19,4 @@ parameters:
- identifier: method.unused
- identifier: new.static
- identifier: trait.unused
checkMissingOverrideMethodAttribute: true
20 changes: 5 additions & 15 deletions wcfsetup/install.php
Original file line number Diff line number Diff line change
Expand Up @@ -886,9 +886,7 @@ public function close()
}
}

/**
* @inheritDoc
*/
#[\Override]
public function getContentList()
{
if (!$this->read) {
Expand All @@ -898,9 +896,7 @@ public function getContentList()
return $this->contentList;
}

/**
* @inheritDoc
*/
#[\Override]
public function getFileInfo($fileIndex)
{
if (!is_int($fileIndex)) {
Expand All @@ -913,9 +909,7 @@ public function getFileInfo($fileIndex)
return $this->contentList[$fileIndex];
}

/**
* @inheritDoc
*/
#[\Override]
public function getIndexByFilename($filename)
{
foreach ($this->contentList as $index => $file) {
Expand All @@ -926,9 +920,7 @@ public function getIndexByFilename($filename)
return false;
}

/**
* @inheritDoc
*/
#[\Override]
public function extractToString($index)
{
if (!$this->read) {
Expand All @@ -955,9 +947,7 @@ public function extractToString($index)
return $content;
}

/**
* @inheritDoc
*/
#[\Override]
public function extract($index, $destination)
{
if (!$this->read) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
*/
final class ArticleCategoryAction implements RequestHandlerInterface
{
#[\Override]
public function handle(ServerRequestInterface $request): ResponseInterface
{
if (!WCF::getSession()->getPermission("admin.content.article.canManageArticle")) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,7 @@
*/
final class CacheClearAction implements RequestHandlerInterface
{
/**
* @inheritDoc
*/
#[\Override]
public function handle(ServerRequestInterface $request): ResponseInterface
{
if (!WCF::getSession()->getPermission('admin.management.canRebuildData')) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -41,9 +41,7 @@ public function __construct()
$this->userConfiguration = $this->dashboard->getUserConfiguration();
}

/**
* @inheritDoc
*/
#[\Override]
public function handle(ServerRequestInterface $request): ResponseInterface
{
if (!WCF::getSession()->getPermission('admin.general.canUseAcp')) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,18 +25,16 @@ final class DevtoolsInstallPackageAction extends InstallPackageAction
*/
public DevtoolsProject $project;

/**
* @inheritDoc
*/
#[\Override]
protected function getRedirectLink(): string
{
return LinkHandler::getInstance()->getLink('DevtoolsProjectList');
}

/**
* @inheritDoc
* @throws IllegalLinkException
*/
#[\Override]
public function readParameters()
{
AbstractSecureAction::readParameters();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
*/
final class FirstTimeSetupAction implements RequestHandlerInterface
{
#[\Override]
public function handle(ServerRequestInterface $request): ResponseInterface
{
WCF::getSession()->checkPermissions([
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,7 @@
*/
final class FullLogoutAction extends LogoutAction
{
/**
* @inheritDoc
*/
#[\Override]
public function execute(): RedirectResponse
{
AbstractSecureAction::execute();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,7 @@ class InstallPackageAction extends AbstractSecureAction

private string $redirectLocation = '';

/**
* @inheritDoc
*/
#[\Override]
public function readParameters()
{
parent::readParameters();
Expand Down Expand Up @@ -72,6 +70,7 @@ public function readParameters()
$this->installation = new PackageInstallationDispatcher($this->queue);
}

#[\Override]
public function execute()
{
parent::execute();
Expand Down
4 changes: 1 addition & 3 deletions wcfsetup/install/files/lib/acp/action/LogoutAction.class.php
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,7 @@ class LogoutAction extends AbstractSecureAction
*/
public $loginRequired = true;

/**
* @inheritDoc
*/
#[\Override]
public function execute()
{
parent::execute();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,7 @@
*/
final class StyleAddDarkModeAction implements RequestHandlerInterface
{
/**
* @inheritDoc
*/
#[\Override]
public function handle(ServerRequestInterface $request): ResponseInterface
{
$parameters = Helper::mapQueryParameters(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,7 @@ final class UninstallPackageAction extends AbstractSecureAction

protected int $packageID = 0;

/**
* @inheritDoc
*/
#[\Override]
public function readParameters()
{
parent::readParameters();
Expand Down Expand Up @@ -76,6 +74,7 @@ public function readParameters()
}
}

#[\Override]
public function execute(): ResponseInterface
{
parent::execute();
Expand Down Expand Up @@ -174,9 +173,6 @@ public function stepUninstall(): ResponseInterface
]);
}

/**
* @inheritDoc
*/
protected function getCurrentAction(?int $queueID, PackageInstallationQueue $queue): string
{
if ($queueID === null) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -126,9 +126,7 @@ final class UserExportGdprAction extends AbstractAction
*/
public $userID = 0;

/**
* @inheritDoc
*/
#[\Override]
public function readParameters()
{
parent::readParameters();
Expand All @@ -147,9 +145,7 @@ public function readParameters()
}
}

/**
* @inheritDoc
*/
#[\Override]
public function execute(): ResponseInterface
{
// you MUST NOT use the `execute` event to provide data, use `export` (see below) instead!
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -69,9 +69,7 @@ final class UserQuickSearchAction extends AbstractAction
*/
public $maxResults = 2000;

/**
* @inheritDoc
*/
#[\Override]
public function readParameters()
{
parent::readParameters();
Expand All @@ -81,9 +79,7 @@ public function readParameters()
}
}

/**
* @inheritDoc
*/
#[\Override]
public function execute(): RedirectResponse
{
ACPMenu::getInstance()->setActiveMenuItem('wcf.acp.menu.link.user.search');
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -46,9 +46,7 @@ final class WorkerProxyAction extends AJAXInvokeAction
*/
public static $allowInvoke = [];

/**
* @inheritDoc
*/
#[\Override]
public function readParameters()
{
AbstractSecureAction::readParameters();
Expand Down Expand Up @@ -82,9 +80,7 @@ protected function validate()
}
}

/**
* @inheritDoc
*/
#[\Override]
public function execute()
{
AbstractSecureAction::execute();
Expand Down Expand Up @@ -120,6 +116,7 @@ public function execute()
* @param string $proceedURL
* @return void
*/
#[\Override]
protected function sendResponse($progress = 0, ?array $parameters = null, $proceedURL = '')
{
if ($parameters === null) {
Expand Down
12 changes: 3 additions & 9 deletions wcfsetup/install/files/lib/acp/form/AbstractAcpForm.class.php
Original file line number Diff line number Diff line change
Expand Up @@ -63,9 +63,7 @@ public function getI18nValue($fieldName)
return $this->i18nValues[$fieldName] ?? null;
}

/**
* @inheritDoc
*/
#[\Override]
public function readFormParameters()
{
parent::readFormParameters();
Expand All @@ -81,9 +79,7 @@ public function readFormParameters()
}
}

/**
* @inheritDoc
*/
#[\Override]
public function validate()
{
parent::validate();
Expand Down Expand Up @@ -212,9 +208,7 @@ public function reset()
WCF::getTPL()->assign('success', true);
}

/**
* @inheritDoc
*/
#[\Override]
public function assignVariables()
{
parent::assignVariables();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -63,9 +63,7 @@ abstract class AbstractBulkProcessingForm extends AbstractForm
*/
public $templateName = 'bulkProcessing';

/**
* @inheritDoc
*/
#[\Override]
public function assignVariables()
{
parent::assignVariables();
Expand All @@ -82,9 +80,7 @@ public function assignVariables()
]);
}

/**
* @inheritDoc
*/
#[\Override]
public function readData()
{
// read bulk processable object type
Expand Down Expand Up @@ -146,9 +142,7 @@ public function readData()
}
}

/**
* @inheritDoc
*/
#[\Override]
public function readFormParameters()
{
parent::readFormParameters();
Expand All @@ -164,9 +158,7 @@ public function readFormParameters()
}
}

/**
* @inheritDoc
*/
#[\Override]
public function save()
{
$action = $this->actions[$this->action]->getProcessor();
Expand Down Expand Up @@ -241,9 +233,7 @@ public function save()
}
}

/**
* @inheritDoc
*/
#[\Override]
public function validate()
{
parent::validate();
Expand Down
Loading
Loading