Various fixes for patch 4#86
Various fixes for patch 4#86Supermario1313 wants to merge 9 commits intoWohlSoft:smbx2-beta5-patch4-pendingfrom
Conversation
|
A lot of this looks interesting, but this is way too much to change in a patch release. The only things that really need to be included in Patch 4 (as far as I'm aware) are crash fixes and security fixes. Maybe you can submit another PR including those only? Edit: I've now skimmed the entire changeset, and I do think most of these probably should be accepted in the long run -- it's just a matter of testing. There is a lot of extra bug surface getting introduced here and I'm not comfortable doing it in a Patch. Let's be surgical in our changes at this point. |
|
Do you have specific commits in mind which should be removed? |
d1b743d to
40731ff
Compare
|
I haven't had time to deeply review this, but as long as the team can test it before release, I'd rather get it merged sooner than later. Let's not let it hold us up. The most important thing is that the release works. |
No description provided.