Skip to content

Fix out-of-bounds array write in POR missing-value reader #376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aaranmcguire wants to merge 1 commit into
base: dev
Choose a base branch
from
+4 −4
Open

Fix out-of-bounds array write in POR missing-value reader #376

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/spss/readstat_por_read.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -372,6 +372,10 @@ static readstat_error_t read_missing_value_record(por_ctx_t *ctx) {
}
varinfo = &ctx->varinfo[ctx->var_offset];

if (varinfo->n_missing_values >= 3) {
retval = READSTAT_ERROR_PARSE;
goto cleanup;
}
if (varinfo->type == READSTAT_TYPE_DOUBLE) {
if ((retval = read_double(ctx, &varinfo->missing_double_values[varinfo->n_missing_values])) != READSTAT_OK) {
goto cleanup;
Expand All @@ -382,10 +386,6 @@ static readstat_error_t read_missing_value_record(por_ctx_t *ctx) {
goto cleanup;
}
}
if (varinfo->n_missing_values > 2) {
retval = READSTAT_ERROR_PARSE;
goto cleanup;
}
varinfo->n_missing_values++;

cleanup:
Expand Down