Skip to content

Conversation

@JoaoSandrini
Copy link

@JoaoSandrini JoaoSandrini commented Feb 7, 2025

Proposed changes

Changed the way the via header is constructed in order to enable compatibility with other NGSI-LD Context Brokers such as Scorpio Broker

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of
them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before
merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

Added the protocol to the via header, in order to enable compatibility with other NGSI-LD Context Brokers such as Scorpio Broker. Now its constructed like / <current_domain> (Wirecloud-python-Proxy/1.1). Tested it in a local environment and works, not sure how to implement the tests to comprove but i'm up to learn how to or help with it if needed.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 7, 2025

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@JoaoSandrini
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

github-actions bot added a commit that referenced this pull request Feb 7, 2025
@oxixes
Copy link
Contributor

oxixes commented Mar 6, 2025

Wirecloud creates a valid Via header, it’s Scorpio the one that does not accept it because of a logic bug in its code which I fixed in ScorpioBroker/ScorpioBroker#614

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants