Skip to content

Conversation

@IamPete1
Copy link
Contributor

@IamPete1 IamPete1 commented Feb 4, 2024

Currently the file parsing does not check the offset, this means that is does not spot missed data and it will concatenate multiple copys into single file. This uses the offset to start a new file. Currently it just appends _Vx to the file name for copies. This is a bit clunky but is a none breaking change. In the future we might want to return a array for each file so the tool can decide how to present the multiple copy's (I was thinking of a drop down selection).

Currently we get this:
image

With this patch:
image

Using @SYS/uarts.txt as a example. We currently get:

UARTV1
SERIAL0 OTG1  TX =       0 RX =       0 TXBD=     0 RXBD=     0
SERIAL1 UART2 TX =    4064 RX*=       0 TXBD=   225 RXBD=     0
SERIAL2 UART3 TX =  509050 RX*= 1704134 TXBD=  4419 RXBD= 23092
SERIAL3 UART4 TX*=    1564 RX*=  111155 TXBD=    86 RXBD=  6175
SERIAL4 UART8 TX =       0 RX*=       0 TXBD=     0 RXBD=     0
SERIAL5 UART7 TX =       0 RX =       0 TXBD=     0 RXBD=     0
SERIAL6 OTG2  TX =       0 RX =       0 TXBD=     0 RXBD=     0
UARTV1
SERIAL0 OTG1  TX =       0 RX =       0 TXBD=     0 RXBD=     0
SERIAL1 UART2 TX =     281 RX*=       0 TXBD=   253 RXBD=     0
SERIAL2 UART3 TX =   36471 RX*=  126109 TXBD= 32856 RXBD=113611
SERIAL3 UART4 TX*=      20 RX*=    7616 TXBD=    18 RXBD=  6861
SERIAL4 UART8 TX =       0 RX*=       0 TXBD=     0 RXBD=     0
SERIAL5 UART7 TX =       0 RX =       0 TXBD=     0 RXBD=     0
SERIAL6 OTG2  TX =       0 RX =       0 TXBD=     0 RXBD=     0
UARTV1
SERIAL0 OTG1  TX =       0 RX =       0 TXBD=     0 RXBD=     0
SERIAL1 UART2 TX =    1452 RX*=       0 TXBD=   235 RXBD=     0
SERIAL2 UART3 TX =  199238 RX*=  274427 TXBD= 32289 RXBD= 44475
SERIAL3 UART4 TX*=     198 RX*=   42166 TXBD=    32 RXBD=  6833
SERIAL4 UART8 TX =       0 RX*=       0 TXBD=     0 RXBD=     0
SERIAL5 UART7 TX =       0 RX =       0 TXBD=     0 RXBD=     0
SERIAL6 OTG2  TX =       0 RX =       0 TXBD=     0 RXBD=     0

With the patch we get:
@SYS/uarts.txt:

UARTV1
SERIAL0 OTG1  TX =       0 RX =       0 TXBD=     0 RXBD=     0
SERIAL1 UART2 TX =    4064 RX*=       0 TXBD=   225 RXBD=     0
SERIAL2 UART3 TX =  509050 RX*= 1704134 TXBD=  4419 RXBD= 23092
SERIAL3 UART4 TX*=    1564 RX*=  111155 TXBD=    86 RXBD=  6175
SERIAL4 UART8 TX =       0 RX*=       0 TXBD=     0 RXBD=     0
SERIAL5 UART7 TX =       0 RX =       0 TXBD=     0 RXBD=     0
SERIAL6 OTG2  TX =       0 RX =       0 TXBD=     0 RXBD=     0

@SYS/uarts_V2.txt:

UARTV1
SERIAL0 OTG1  TX =       0 RX =       0 TXBD=     0 RXBD=     0
SERIAL1 UART2 TX =     281 RX*=       0 TXBD=   253 RXBD=     0
SERIAL2 UART3 TX =   36471 RX*=  126109 TXBD= 32856 RXBD=113611
SERIAL3 UART4 TX*=      20 RX*=    7616 TXBD=    18 RXBD=  6861
SERIAL4 UART8 TX =       0 RX*=       0 TXBD=     0 RXBD=     0
SERIAL5 UART7 TX =       0 RX =       0 TXBD=     0 RXBD=     0
SERIAL6 OTG2  TX =       0 RX =       0 TXBD=     0 RXBD=     0

@SYS/uarts_V3.txt:

UARTV1
SERIAL0 OTG1  TX =       0 RX =       0 TXBD=     0 RXBD=     0
SERIAL1 UART2 TX =    1452 RX*=       0 TXBD=   235 RXBD=     0
SERIAL2 UART3 TX =  199238 RX*=  274427 TXBD= 32289 RXBD= 44475
SERIAL3 UART4 TX*=     198 RX*=   42166 TXBD=    32 RXBD=  6833
SERIAL4 UART8 TX =       0 RX*=       0 TXBD=     0 RXBD=     0
SERIAL5 UART7 TX =       0 RX =       0 TXBD=     0 RXBD=     0
SERIAL6 OTG2  TX =       0 RX =       0 TXBD=     0 RXBD=     0

This does do a file compare, so you will only get a new version if it is different.

@IamPete1 IamPete1 force-pushed the files_split branch 2 times, most recently from 46de690 to 1b23604 Compare April 11, 2024 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant