Conversation
Collaborator
haoruizhou
commented
Nov 14, 2025
- data-downloader/backend/services.py:71 now feeds the sensor collector with fallback start/end timestamps derived from the freshly scanned run windows, eliminating the static date dependency and ensuring both scanners stay in sync; the helper at data-downloader/backend/services.py:124 safely scans the windows, normalizes them to UTC, and only returns a range when it is valid so the SQL chunking logic in backend/ sql.py stays unchanged and memory-friendly.
- data-downloader/backend/config.py:31 drops the unused SENSOR_FALLBACK_* settings so the app no longer advertises manual fallback tuning knobs that would fight the new automatic behavior.
- data-downloader/README.md:35 explains the new automatic fallback derived from the date scanner, and data- downloader/.env.example:11 removes the obsolete environment variables from the sample configuration to keep deploys aligned with the new flow.
- data-downloader/backend/services.py:71 now feeds the sensor collector with fallback start/end timestamps
derived from the freshly scanned run windows, eliminating the static date dependency and ensuring both
scanners stay in sync; the helper at data-downloader/backend/services.py:124 safely scans the windows,
normalizes them to UTC, and only returns a range when it is valid so the SQL chunking logic in backend/
sql.py stays unchanged and memory-friendly.
- data-downloader/backend/config.py:31 drops the unused SENSOR_FALLBACK_* settings so the app no longer
advertises manual fallback tuning knobs that would fight the new automatic behavior.
- data-downloader/README.md:35 explains the new automatic fallback derived from the date scanner, and data-
downloader/.env.example:11 removes the obsolete environment variables from the sample configuration to
keep deploys aligned with the new flow.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR replaces the static sensor fallback date configuration with an automatic fallback mechanism that derives start/end timestamps from the scanned run windows. This ensures the run scanner and sensor collector remain synchronized without manual date configuration.
- Implements
_build_sensor_fallback_rangehelper to compute fallback dates from scanned runs - Removes
SENSOR_FALLBACK_STARTandSENSOR_FALLBACK_ENDconfiguration settings - Updates documentation to reflect the new automatic behavior
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
installer/data-downloader/backend/services.py |
Adds helper method to build sensor fallback range from scanned runs and integrates it into the scan workflow |
installer/data-downloader/backend/config.py |
Removes obsolete sensor fallback configuration fields |
installer/data-downloader/README.md |
Updates documentation to explain the new automatic fallback behavior |
installer/data-downloader/.env.example |
Removes deprecated environment variable examples |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.