fix(macros): respect local feature in #[prompt] macro — omit + Send bound#1
Open
WeekendSuperhero wants to merge 2 commits intomainfrom
Open
fix(macros): respect local feature in #[prompt] macro — omit + Send bound#1WeekendSuperhero wants to merge 2 commits intomainfrom
local feature in #[prompt] macro — omit + Send bound#1WeekendSuperhero wants to merge 2 commits intomainfrom
Conversation
WeekendSuperhero
changed the title
local feature in #[prompt] macro — omit + Send boundlocal feature in #[prompt] macro — omit + Send bound
WeekendSuperhero
force-pushed
the
WeekendSuperhero-patch-1
branch
from
d448cfa to
29f15fa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes modelcontextprotocol#801
The
#[prompt]macro unconditionally emits+ Sendon generated handler futures, preventing!Sendtypes from being used in prompt handlers even when thelocalcrate feature is enabled.This brings
#[prompt]to parity with#[tool], which already checkscfg!(feature = "local")to conditionally omit theSendbound (tool.rs:341).Changes
let omit_send = cfg!(feature = "local");in the prompt return type generation+ Sendbehind!omit_sendfor bothReturnType::DefaultandReturnType::Typearms