Skip to content

chore: bump scaffold to Astro 6#1

Open
rjbeers wants to merge 1 commit into
mainfrom
v2
Open

chore: bump scaffold to Astro 6#1
rjbeers wants to merge 1 commit into
mainfrom
v2

Conversation

@rjbeers
Copy link
Copy Markdown

@rjbeers rjbeers commented May 29, 2026

Minimal Astro 5 → Astro 6 conversion:

  • package.json: bump astro to ^6.1.4, @astrojs/cloudflare to ^13.5.0, @astrojs/react to ^5.0.0. Add engines.node >=22.12.0 and overrides.vite ^7 (Astro 6 + @cloudflare/vite-plugin require vite v7).
  • wrangler.json: drop the main field (@cloudflare/vite-plugin@1.37+ validates main as an existing file before build runs; the plugin computes the entry itself for Astro 6 SSR output). Point assets.directory at ./dist/client to match the Astro 6 output layout.

Minimal Astro 5 → Astro 6 conversion:

- package.json: bump astro to ^6.1.4, @astrojs/cloudflare to ^13.5.0,
  @astrojs/react to ^5.0.0. Add engines.node >=22.12.0 and
  overrides.vite ^7 (Astro 6 + @cloudflare/vite-plugin require vite v7).
- wrangler.json: drop the `main` field (@cloudflare/vite-plugin@1.37+
  validates main as an existing file before build runs; the plugin
  computes the entry itself for Astro 6 SSR output). Point assets.directory
  at ./dist/client to match the Astro 6 output layout.
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0f1dc19345

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread package.json
Comment on lines +20 to +24
"@astrojs/cloudflare": "^13.5.0",
"@astrojs/react": "^5.0.0",
"@types/react": "^19.1.2",
"@types/react-dom": "^19.1.2",
"astro": "^5.7.0",
"astro": "^6.1.4",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Update the lockfile with the Astro 6 dependency bump

Because this repo tracks package-lock.json, changing these package ranges without regenerating the lock leaves the lockfile root and resolved packages on @astrojs/cloudflare 12.x, @astrojs/react 4.x, and astro 5.x. I checked the lockfile and it still records the old root dependency ranges and installed versions, so clean installs/deploys that use npm ci (confirmed via npm ci --help as the clean-install command) will not install the Astro 6 stack described by this change and can fail due to the package/lock mismatch. Please update and commit package-lock.json alongside these dependency changes.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants