Delete npm cache before packaging - closes #355 #356
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benfrancis
force-pushed
the
fix-checksum
branch
from
b4b97f9 to
9bc8d6d
Compare
Member
Author
|
r=me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know why this .package-lock.json file is placed in node_modules/ or why it gets modified after packaging and installation on the gateway but this is causing the checksum of the add-on to fail at startup.
From what I have read this is an internal cache created by npm which can safely be deleted, so I have modified the packaging script to delete it before distribution. This seems to fix the checksum errors seen in #355.
Closes #355.