Update for x10-cm11-adapter v0.6.5 for gateway v2.0.0+. #1493
Conversation
benfrancis
left a comment
benfrancis
left a comment
There was a problem hiding this comment.
This looks good, thank you.
I think we'll need to change the minimum version in order for this to be available for 2.0.0-beta.1 though.
I would suggest setting it to 2.0.0-beta.1 at first to see if that works, and if it doesn't then we might have to reduce it down to 1.0.0 (but with Node version 115) until we figure out a fix on the addon-proxy side.
I have filed WebThingsIO/addon-proxy#18 to track this in the addon-proxy repo.
addons/x10-cm11-adapter.json
Outdated
| "url": "https://github.com/AlanDThiessen/x10-cm11-adapter/releases/download/v0.6.5/x10-cm11-adapter-0.6.5-linux-arm-v20.tgz", | ||
| "checksum": "02b1b2dbfdb3c48b085d5d6332724dfdca83a64d0497b09e1d11c729cc93fc31", | ||
| "gateway": { | ||
| "min": "2.0.0", |
There was a problem hiding this comment.
One slight issue with this is that I think the semver library will evaluate 2.0.0 as being newer than 2.0.0-beta.1 and therefore conclude that this add-on is not compatible with 2.0.0-beta.1 - so it won't show up in the list for that version. I had this issue with the Zigbee add-on.
In the case of the Zigbee add-on I just set it to 1.0.0 but requiring Node.js 20 (aka 115).
I would be interested to see if it works if we set min to 2.0.0-beta.1 though, since that is more accurate.
There was a problem hiding this comment.
The commit checks failed the "2.0.0-beta.1" because it did not match the predefined pattern, so I changed it to 1.0.0.
There was a problem hiding this comment.
Now it failed the check with the package version. Is this level of coupling really necessary?
There was a problem hiding this comment.
Pre-checks have been appeased! :-)
There was a problem hiding this comment.
@AlanDThiessen wrote:
The commit checks failed the "2.0.0-beta.1" because it did not match the predefined pattern
Oh yeah I forgot about that, sorry. I have filed #1494 to fix that.
In the meantime let's go with minimum gateway 1.0.0 but Node.js 115 as you have done here, which is what I did for the Zigbee add-on too.
…0.0 in the addon list.
|
This will take a while to propagate because the add-on proxy caches results for a while, but let me know if this works! Thank you 😊 |
2 participants
Update x10-cm11-adapter to version 0.6.5 with updated dependencies which support NodeJS version 20.
In particular, the cm11a-js node module now uses serialport 12.0.0.