Skip to content

Tweak NewsSite test step scenarios#454

Open
lingyuncai wants to merge 1 commit intoWebKit:mainfrom
lingyuncai:newssite-test-steps
Open

Tweak NewsSite test step scenarios#454
lingyuncai wants to merge 1 commit intoWebKit:mainfrom
lingyuncai:newssite-test-steps

Conversation

@lingyuncai
Copy link
Copy Markdown

This proof of concept illustrates potential tweaks to the test steps for the NewsSite workload. It introduces an extra navigation to a new tab instead of repeatedly toggling the drop-down menu.

image

@camillobruni
Copy link
Copy Markdown
Contributor

I'm not opposed to this change in general. @flashdesignory what's your take here?
How much slower does the test run now?

@camillobruni
Copy link
Copy Markdown
Contributor

btw, you can use crossbench to create browser comparison data easily.

@lingyuncai
Copy link
Copy Markdown
Author

Hi @camillobruni, thanks for your comments.

Below are the crossbench results for this PR from 10 runs. We ran the whole benchmark and extracted the scores for NewsSite cases.

this PR

browser              Google Chrome        Firefox              Safari
NewsSite-Next        75.03 ± 0.92%        64.70 ± 0.90%        86.99 ± 0.61%
NewsSite-Nuxt        47.72 ± 0.98%        53.09 ± 1.2%         59.44 ± 0.92%
Score                36.45 ± 0.63%        31.74 ± 0.67%        31.41 ± 0.45%

main

browser              Google Chrome        Firefox              Safari
NewsSite-Next        64.35 ± 0.79%        63.03 ± 0.80%        71.6 ± 1.9%
NewsSite-Nuxt        62.70 ± 0.85%        70.6 ± 1.8%          76.33 ± 0.14%
Score                36.21 ± 0.53%        31.45 ± 0.90%        31.34 ± 0.59%

System and browser version

browser              Google Chrome        Firefox              Safari
version              131.0.6778.86        133.0                19618.1.15.11.12
os                   macos 14.4 arm64     macos 14.4 arm64     macos 14.4 arm64
device               Mac14,7              Mac14,7              Mac14,7
cpu                  Apple M2 8 cores     Apple M2 8 cores     Apple M2 8 cores
runs                 10                   10                   10
failed runs          0                    0                    0

Basically, NewsSite-Next runs slower while NewsSite-Nuxt runs faster. This difference is related to how each framework handles router.push().

In NewsSite-Nuxt, the Vue router leverages microtasks for its navigation mechanism, so a forced layout of a new tab does not happen synchronously. However, in NewsSite-Next, router.push() is executed synchronously, resulting in a forced layout in sync time when clicking the drop-down menu again.

@lingyuncai
Copy link
Copy Markdown
Author

Hi @camillobruni,

Just kindly ping :) Do you have any comments or suggestions on this idea? Thank you!

@camillobruni
Copy link
Copy Markdown
Contributor

Could you try kicking off the try-jobs again?

@lingyuncai lingyuncai force-pushed the newssite-test-steps branch from 3d2f487 to 1411d4a Compare May 22, 2025 01:24
@netlify
Copy link
Copy Markdown

netlify Bot commented May 22, 2025

Deploy Preview for webkit-speedometer-preview ready!

Name Link
🔨 Latest commit 1411d4a
🔍 Latest deploy log https://app.netlify.com/projects/webkit-speedometer-preview/deploys/682e7cccde06850008775df0
😎 Deploy Preview https://deploy-preview-454--webkit-speedometer-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@lingyuncai
Copy link
Copy Markdown
Author

Hi @camillobruni, I just did a rebase and triggered a new round of CI runs.

Copy link
Copy Markdown
Contributor

@camillobruni camillobruni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from my side, slightly more complexity than the original workload SGTM.

@lingyuncai lingyuncai force-pushed the newssite-test-steps branch from 1411d4a to 967f955 Compare May 6, 2026 05:40
@netlify
Copy link
Copy Markdown

netlify Bot commented May 6, 2026

Deploy Preview for webkit-speedometer-preview ready!

Name Link
🔨 Latest commit 967f955
🔍 Latest deploy log https://app.netlify.com/projects/webkit-speedometer-preview/deploys/69fad4322a2a320008333d98
😎 Deploy Preview https://deploy-preview-454--webkit-speedometer-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@lingyuncai lingyuncai marked this pull request as ready for review May 6, 2026 05:41
@lingyuncai
Copy link
Copy Markdown
Author

Hi @camillobruni, thanks for the review! I just rebased the PR onto ToT. Do you think we need an additional pair of eyes on this PR? If so, could you please help invite someone you think would be appropriate? Feel free to let me know if any changes are required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants