Skip to content

Fix update-ui performance.measure nesting #307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
camillobruni wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −3
Open

Fix update-ui performance.measure nesting #307

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions JetStreamDriver.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -344,9 +344,9 @@ class Driver {
} else if (!JetStreamParams.dumpJSONResults)
console.log("Starting JetStream3");

performance.mark("update-ui-start");
const start = performance.now();
for (const benchmark of this.benchmarks) {
performance.mark("update-ui-start");
await benchmark.updateUIBeforeRun();
await updateUI();
performance.measure("runner update-ui", "update-ui-start");
Expand All @@ -358,14 +358,14 @@ class Driver {
throw e;
}

performance.mark("update-ui");
performance.mark("update-ui-start");
benchmark.updateUIAfterRun();
performance.measure("runner update-ui", "update-ui-start");

if (isInBrowser) {
browserFileLoader.free(benchmark.files);
}
}
performance.measure("runner update-ui", "update-ui-start");

const totalTime = performance.now() - start;
if (measureTotalTimeAsSubtest) {
Expand Down
Loading