Filter blank failedWhere Queries from mutator#1482
Draft
agusaldasoro wants to merge 1 commit intomasterfrom
Draft
Filter blank failedWhere Queries from mutator#1482agusaldasoro wants to merge 1 commit intomasterfrom
agusaldasoro wants to merge 1 commit intomasterfrom
Conversation
We were sending empty strings as a valid query
jgaleotti
reviewed
Mar 20, 2026
| val oldSqlActions = mutableListOf<EnvironmentAction>().plus(ind.seeInitializingActions()) | ||
|
|
||
| val failedWhereQueries = evaluatedIndividual.fitness.getViewOfAggregatedFailedWhereQueries() | ||
| .filter { it.isNotBlank() } |
Collaborator
There was a problem hiding this comment.
Would that be too complicate to add a test case for checking that no blank queries are sent?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes a focused improvement to the mutation logic for handling failed SQL WHERE queries in the
ApiWsStructureMutatorclass. The main change ensures that only non-blank failed WHERE queries are processed, which helps prevent unnecessary or invalid operations during mutation. We were sending empty strings as a valid query.ApiWsStructureMutator, the list of failed WHERE queries is now filtered to exclude blank entries before further processing. This helps avoid issues related to empty or invalid SQL queries during mutation.