-
Notifications
You must be signed in to change notification settings - Fork 106
Regex support for missing predefined character classes and negated character classes #1474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
8c03d8b
147d40c
7f40c66
74b6136
8db3796
fa88731
2c9793c
5ce41e2
75385cf
bc91846
3a863c7
1c7861c
8c31907
bd17853
897f04b
19b336c
56a7462
a0d3ea9
22461a1
bd9a0f1
a1d1e32
7c851fc
4d360dd
e9780d9
fededcf
9822f49
09cf21d
7327816
719c148
02fcfc4
fc407bf
abefd64
f848529
0c881c0
bfb0aca
9ba041d
2c114aa
df807cc
3a0afa1
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -97,6 +97,7 @@ paths: | |
| - aDouble | ||
| - aFloat | ||
| - aBoolean | ||
| - aNullableString | ||
| responses: | ||
| '200': | ||
| description: OK | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -125,9 +125,29 @@ fragment CharacterEscape | |
| | HexEscapeSequence | ||
| | UnicodeEscapeSequence | ||
| | OctalEscapeSequence | ||
| | 'p' BRACE_open PosixCharacterClassLabel BRACE_close // this is only implemented in Java at the moment as on JS this | ||
| // is allowed only while certain flags are enabled | ||
| //| IdentityEscape | ||
| ; | ||
|
|
||
| // basic US-ASCII only predefined POSIX character classes | ||
| // https://docs.oracle.com/javase/8/docs/api/java/util/regex/Pattern.html#:~:text=character%3A%20%5B%5E%5Cw%5D-,POSIX,-character%20classes%20(US | ||
| fragment PosixCharacterClassLabel | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. provide reference link from where those values were taken from. recall the comments at the top of this file |
||
| : 'Lower' | ||
| | 'Upper' | ||
| | 'ASCII' | ||
| | 'Alpha' | ||
| | 'Digit' | ||
| | 'Alnum' | ||
| | 'Punct' | ||
| | 'Graph' | ||
| | 'Print' | ||
| | 'Blank' | ||
| | 'Cntrl' | ||
| | 'XDigit' | ||
| | 'Space' | ||
| ; | ||
|
|
||
| fragment ControlEscape | ||
| //one of f n r t v | ||
| : [aefnrt] | ||
|
|
@@ -233,8 +253,10 @@ AtomEscape | |
| ; | ||
|
|
||
| fragment CharacterClassEscape | ||
| //one of d D s S w W | ||
| : [dDsSwW] | ||
| //one of d D s S w W v V h H | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. as |
||
| // v, V, h and H are java8 exclusive, they represent vertical spaces and horizaontal spaces respectively | ||
| // see https://docs.oracle.com/javase/8/docs/api/java/util/regex/Pattern.html for more information | ||
| : [dDsSwWvVhH] | ||
| ; | ||
|
|
||
|
|
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why this change?
@Pgarrett you wrote this file, isn't it? what is your opinion on this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes I did, it seemed one of the fields was not being generated in the test and thus causing the test to fail in the reflective assertions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No concern on my side