Elaboration of subtyping rule of struct and variant in SpecTec IL#2111
Open
jihongmin63 wants to merge 4 commits intoWebAssembly:mainfrom
Open
Elaboration of subtyping rule of struct and variant in SpecTec IL#2111jihongmin63 wants to merge 4 commits intoWebAssembly:mainfrom
jihongmin63 wants to merge 4 commits intoWebAssembly:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I elaborate the subtyping rule of struct and variant.
The current implementation did not strictly account for the premise-dropping behavior defined in the documentation. Specifically:
So I categorized the premises for the smaller and the larger types, and revised the subtyping logic to ensure the larger type's premises are correctly contained within the smaller type's premises.
As there is no specific mention of this in the IL syntax, I would appreciate it if you could verify if this approach is correct.