[wasm-split] Tidy up indirectCallsToSecondaryFunctions (NFC)#8726
Merged
Conversation
This avoids computing repeated expression multiple times and removes an unnecessary if condition.
aheejin
commented
May 19, 2026
| // Return if the current module is the same module as the call's target, | ||
| // because we don't need a call_indirect within the same module. | ||
| Module* currModule = getModule(); | ||
| if (currModule != &parent.primary && |
Member
Author
There was a problem hiding this comment.
This currModule != &parent.primary is not necessary because we already filter out when the callee's module is the primary module at the top of the function:
binaryen/src/ir/module-splitting.cpp
Lines 993 to 996 in 2c2509b
So if
currModule == calleeModule here, that means currModule is not a primary module anyway.
aheejin
commented
May 19, 2026
| if (!secondaryGlobal) { | ||
| secondaryGlobal = ModuleUtils::copyGlobal(primaryGlobal, secondary); | ||
| makeImportExport( | ||
| *primaryGlobal, *secondaryGlobal, "global", ExternalKind::Global); |
Member
Author
There was a problem hiding this comment.
Drive-by NFC fix: This is only necessary when we copied the global. There is no harm in calling makeImportExport again on it though.
kripken
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This avoids computing repeated expression multiple times and removes an unnecessary if condition.