Fix dangling Instance references in interpreter store #8296
+34
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rage WasmStore::instances was a std::vector<Instance>, but Frame holds Instance& references. Vector reallocation when adding new instances would silently invalidate all frame references, leading to use-after-free. Switch to std::deque which guarantees that references to existing elements are not invalidated by push_back/emplace_back.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
WasmStore::instanceswas astd::vector<Instance>, butFrameholdsInstance&references. Vector reallocation when adding new instances invalidates all frame references, leading to use-after-free.instancestostd::deque<Instance>, which guarantees that references to existing elements are not invalidated bypush_back/emplace_back.Test plan
InterpreterTest.InstanceReferenceStability— verifies that adding 100 instances does not relocate existing instances or invalidate frame references