Fix crash in interpreter when instantiating modules with imported globals #8295
+51
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bals instantiate() iterated all globals without checking imported(), causing ExpressionIterator to be constructed with a null init expression. This triggered an assertion failure in PostWalker::walk(). Skip imported globals during instantiation, matching the pattern used by walkModule().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Interpreter::instantiate()iterates all globals without checkingimported(), causingExpressionIteratorto be constructed with a nullinitexpression for imported globals. This triggers an assertion failure inPostWalker::walk()(debug) or a null-pointer dereference (release).global->imported()check to skip imported globals during instantiation, matching the pattern used bywalkModule()inwasm-traversal.h.Test plan
InterpreterTest.ImportedGlobalI32— verifiesaddInstancesucceeds with an imported globalInterpreterTest.MixedImportedAndLocalGlobals— verifies a local global is correctly initialized when an imported global is also present