Fix updateSymbol calls misplaced inside loop in copyFunctionWithoutAdd #8294
+70
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
updateSymbolcalls forprologLocation/epilogLocationoutside thedebugLocationsloop incopyFunctionWithoutAdd, matching the pattern of theupdateLocationcalls in thefileIndexMapblock aboveThe
updateSymbolcalls were a copy-paste error from thefileIndexMapblock. Being inside the loop caused two issues:debugLocationsis empty, the loop never executes andprologLocation/epilogLocationsymbol indices are never remappeddebugLocationshas multiple entries, the indices are double-remapped (or cause OOB access)Test plan
source-map.cpp:UpdateSymbolOutsideLoop: verifies remapping works whendebugLocationsis emptyUpdateSymbolNotDoubleRemapped: verifies remapping happens exactly once with multiple debug locations