Fix wrong loop variable in processResumeHandlers #8289
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
processResumeHandlers(src/ir/subtype-exprs.h), the inner loop uses the outer loop variableiinstead ofjto index intotagSig.paramsandexpected:This produces wrong subtyping constraints for resume handlers whose tags have multiple parameters. It also causes out-of-bounds access when the handler index
iis >= the tag's parameter count.Fix:
[i]->[j](one-character change).Test: added a case with two handlers — one single-param tag and one two-param tag — and verified the correct (Type, Type) pairs are noted.