Fuzzer: Add log-anyref etc. methods #8287
Open
+232
−82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kripken
commented
Feb 10, 2026
| from the random input. Please report it with | ||
| seed: %(seed)d | ||
| seed: {seed} |
Member
Author
There was a problem hiding this comment.
drive-by fix: this was not logging the number before.
tlively
reviewed
Feb 11, 2026
Comment on lines
45
to
47
| // - funcref cannot be logged because referenced functions can be inlined or | ||
| // removed during optimization | ||
| // - there's no point in logging anyref because it is opaque |
Member
There was a problem hiding this comment.
Looks like this comment needs updating.
| loggableTypes.push_back(Type(HeapType::cont, Nullable)); | ||
| } | ||
| if (wasm.features.hasExceptionHandling()) { | ||
| loggableTypes.push_back(Type(HeapType::exn, Nullable)); |
Member
There was a problem hiding this comment.
I don't think exnref values can flow out to JS, so I don't think it makes sense to try to log them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These functions receive a reference value. We cannot log their
internals, but we can try to do some operations on them, and
this gets more such values moving across the JS/wasm
boundary. Future fuzzing of configureAll will build on this.
To achieve this, the
logValuemethod had to be moved up inthe fuzzer, so we can use it from another place. The only
change there is to make it stop printing newlines all the time
(and let the caller do it, if needed).