Fix type conflicts preventing text round-tripping #8285
Merged
+69
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When IRBuilder creates a multivalue block wrapping a set and get of a tuple scratch local, it might be implicitly adding a function type to the module. Text round-tripping could previously fail if that function type would conflict with another function type in the module after binary writing, for example if it contained a bottom reference type with GC disabled. Fix the problem by generalizing the type of scratch locals to be the types that will eventually be written to a binary given the enabled features. This further pessimizes our handling of multivalue code by losing type information in the scratch locals, but handling multivalue better will require a much more systematic change anyway. Fixes #8279.
kripken
approved these changes
Feb 10, 2026
Co-authored-by: Alon Zakai <azakai@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When IRBuilder creates a multivalue block wrapping a set and get of a
tuple scratch local, it might be implicitly adding a function type to
the module. Text round-tripping could previously fail if that function
type would conflict with another function type in the module after
binary writing, for example if it contained a bottom reference type with
GC disabled. Fix the problem by generalizing the type of scratch locals
to be the types that will eventually be written to a binary given the
enabled features.
This further pessimizes our handling of multivalue code by losing type
information in the scratch locals, but handling multivalue better will
require a much more systematic change anyway.
Fixes #8279.