Skip to content

Fix BinaryenAddTagImport using getGlobalOrNull instead of getTagOrNull #8281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kripken merged 1 commit into from
Feb 10, 2026
Merged

Fix BinaryenAddTagImport using getGlobalOrNull instead of getTagOrNull #8281

kripken merged 1 commit into from
Feb 10, 2026
+1 −1

Conversation

@sumleo
Copy link
Contributor

@sumleo sumleo commented Feb 10, 2026

Summary

  • Fix copy-paste bug in BinaryenAddTagImport where getGlobalOrNull was used instead of getTagOrNull

Fixes #8272.

@sumleo
Fix BinaryenAddTagImport using getGlobalOrNull instead of getTagOrNull (
5dd79cc 
WebAssembly#8272)

Copy-paste bug from BinaryenAddGlobalImport caused BinaryenAddTagImport
to look up globals instead of tags.
@sumleo sumleo mentioned this pull request Feb 10, 2026
Closed
kripken
kripken approved these changes Feb 10, 2026
View reviewed changes
Copy link
Member

@kripken kripken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kripken kripken merged commit 93267c5 into WebAssembly:main Feb 10, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kripken kripken kripken approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

BinaryenAddTagImport calls getGlobalOrNull instead of getTagOrNull

2 participants

@sumleo @kripken