Skip to content

feat: multi curve support #216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ieow wants to merge 3 commits into from
Closed

feat: multi curve support #216

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e61342e
feat: initial commit
ieow Feb 7, 2025
9a25f60
fix: add randomId verifier testcases
ieow Feb 10, 2025
b80ad8a
fix: enable multicurve
ieow Feb 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
283 changes: 78 additions & 205 deletions package-lock.json
View file
Open in desktop

Large diffs are not rendered by default.

10 changes: 5 additions & 5 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,20 +47,20 @@
}
},
"dependencies": {
"@tkey/common-types": "^15.1.0",
"@tkey/core": "^15.1.0",
"@tkey/common-types": "file:../tkey/packages/common-types",
"@tkey/core": "file:../tkey/packages/core/tkey-core-15.2.1-alpha.0.tgz",
"@tkey/share-serialization": "^15.1.0",
"@tkey/storage-layer-torus": "^15.1.0",
"@tkey/tss": "^15.1.0",
"@tkey/storage-layer-torus": "file:../tkey/packages/storage-layer-torus/tkey-storage-layer-torus-15.2.1-alpha.0.tgz",
"@tkey/tss": "file:../tkey/packages/tss/tkey-tss-15.2.1-alpha.0.tgz",
Comment on lines +50 to +54
Copy link
Contributor

@matthiasgeihs matthiasgeihs Feb 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix this

"@toruslabs/constants": "^14.2.0",
"@toruslabs/customauth": "^20.3.0",
"@toruslabs/elliptic-wrapper": "^0.1.1",
"@toruslabs/fetch-node-details": "^14.2.0",
"@toruslabs/fnd-base": "^14.2.0",
"@toruslabs/metadata-helpers": "^6.0.0",
"@toruslabs/openlogin-utils": "^8.2.1",
"@toruslabs/torus.js": "15.2.0-alpha.0",
"@toruslabs/session-manager": "^3.1.0",
"@toruslabs/torus.js": "file:../torus.js/toruslabs-torus.js-15.1.1.tgz",
Copy link
Contributor

@matthiasgeihs matthiasgeihs Feb 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix

"@toruslabs/tss-client": "^3.3.0-alpha.0",
"@toruslabs/tss-frost-client": "^1.0.1-alpha.0",
"@toruslabs/tss-frost-common": "^1.0.2-alpha.0",
Expand Down
21 changes: 17 additions & 4 deletions src/interfaces.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,9 @@ export type OAuthLoginParams = (SubVerifierDetailsParams | AggregateVerifierLogi
/**
* Key to import key into Tss during first time login.
*/
importTssKey?: string;
importTssKey?: {
[K in KeyType]: string;
};

/**
* For new users, use SFA key if user was registered with SFA before.
Expand Down Expand Up @@ -161,7 +163,9 @@ export interface JWTLoginParams {
/**
* Key to import key into Tss during first time login.
*/
importTssKey?: string;
importTssKey?: {
[K in KeyType]?: string;
};

/**
* For new users, use SFA key if user was registered with SFA before.
Expand Down Expand Up @@ -201,7 +205,7 @@ export interface Web3AuthOptions {
/**
* The threshold signing library to use.
*/
tssLib: TssLibType;
tssLibs: TssLibType[];

/**
* @defaultValue `false`
Expand Down Expand Up @@ -333,6 +337,15 @@ export interface Web3AuthOptions {
* only scalar will be exported, scalar can be used for signing outside of this sdk but not for importing the key in other wallets.
*/
useClientGeneratedTSSKey?: boolean;

/**
* @defaultValue `false`
* Set this flag to true to use the legacy flag for signing
* legacy flag do not support multicurve mode
* legacy ed25519 customAuth is only supported in legacy mode
* Note: This option is set to false by default.
*/
Comment on lines +341 to +347
Copy link
Contributor

@matthiasgeihs matthiasgeihs Feb 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/**
* @defaultValue `false`
* Set this flag to true to use the legacy flag for signing
* legacy flag do not support multicurve mode
* legacy ed25519 customAuth is only supported in legacy mode
* Note: This option is set to false by default.
*/
/**
* @defaultValue `false`
* Set this flag to true to use the legacy mode.
* Legacy mode does not support multi-curve.
* CustomAuth with key type ed25519 is only supported in legacy mode.
* Note: This option is set to false by default.
*/

I like that this has a comment, but it's a bit raw. could add some punctuation and revise language.

legacyFlag?: boolean;
}
export type Web3AuthOptionsWithDefaults = Required<Web3AuthOptions>;

Expand All @@ -345,7 +358,7 @@ export interface IMPCContext {
updateState: (newState: Partial<Web3AuthState>) => void;
getUserInfo: () => UserInfo;
setupTkey: (params?: {
providedImportKey?: string;
providedImportKey?: { [key in KeyType]?: string };
sfaLoginResponse?: TorusKey | TorusLoginResponse | TorusAggregateLoginResponse;
userInfo?: UserInfo;
importingSFAKey?: boolean;
Expand Down
Loading
Loading