Open
Conversation
| </head> | ||
|
|
||
| <body> | ||
| <noscript> |
There was a problem hiding this comment.
Removed Buffer polyfill but library still uses Buffer
Medium Severity
The <script> tag that polyfilled Buffer and process on window was removed, but src/ed25519/utils.ts still calls Buffer.from() extensively and getED25519Key returns Buffer types. The vue-example's App.vue still imports and calls getED25519Key, and the Vite config has no Buffer resolution or polyfill. This will cause a ReferenceError: Buffer is not defined at runtime in the browser when that code path is exercised.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Motivation and Context
Jira Link
https://consensyssoftware.atlassian.net/browse/W3APD-5248
Description
Stack upgrade:
How has this been tested?
Screenshots (if appropriate):
Types of changes
Checklist:
Note
Medium Risk
Raising the Node baseline to 24 can break contributors/consumers still on older runtimes and may expose dependency/runtime incompatibilities. Removing the demo’s
Buffer/processpolyfill could also cause browser runtime issues if any dependencies still rely on those globals.Overview
Updates the project stack baseline to Node 24. CI now runs on Node
24.xand.nvmrcis updated to>=24.x.Documentation is updated to reflect new build output entrypoints (
dist/lib.esm/index.jsanddist/lib.cjs/index.js, dropping the previously documented UMD paths). The Vue exampleindex.htmlis cleaned up and the inlineBuffer/processbrowser polyfill snippet is removed (along with minor HTML formatting/doctype normalization).Written by Cursor Bugbot for commit d9f5aec. This will update automatically on new commits. Configure here.