Skip to content

Comments

V11 Stack Upgrade#378

Open
arch1995 wants to merge 5 commits intomasterfrom
feat/stack-upgrade
Open

V11 Stack Upgrade#378
arch1995 wants to merge 5 commits intomasterfrom
feat/stack-upgrade

Conversation

@arch1995
Copy link
Contributor

@arch1995 arch1995 commented Feb 20, 2026

Motivation and Context

Jira Link

https://consensyssoftware.atlassian.net/browse/W3APD-5248

Description

Stack upgrade:

  • Remove umd build & webpack
  • Upgrade all deps to latest
  • Drop node 20 support. All repos .nvmrc min as node 22
  • keep node 24 as active and all lock files to point to node 24
  • Remove buffer
  • Updates messageStreams, mux etc
  • Removes tts-custom-error, enc-utils, @ethereumjs/util, end-of-stream
  • Remove bn.js
  • Removes starkey
  • Update demo apps

How has this been tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project. (run lint)
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My code requires a db migration.

Note

Medium Risk
Raising the Node baseline to 24 can break contributors/consumers still on older runtimes and may expose dependency/runtime incompatibilities. Removing the demo’s Buffer/process polyfill could also cause browser runtime issues if any dependencies still rely on those globals.

Overview
Updates the project stack baseline to Node 24. CI now runs on Node 24.x and .nvmrc is updated to >=24.x.

Documentation is updated to reflect new build output entrypoints (dist/lib.esm/index.js and dist/lib.cjs/index.js, dropping the previously documented UMD paths). The Vue example index.html is cleaned up and the inline Buffer/process browser polyfill snippet is removed (along with minor HTML formatting/doctype normalization).

Written by Cursor Bugbot for commit d9f5aec. This will update automatically on new commits. Configure here.

@arch1995 arch1995 marked this pull request as draft February 20, 2026 20:04
@chaitanyapotti chaitanyapotti marked this pull request as ready for review February 21, 2026 09:36
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

</head>

<body>
<noscript>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed Buffer polyfill but library still uses Buffer

Medium Severity

The <script> tag that polyfilled Buffer and process on window was removed, but src/ed25519/utils.ts still calls Buffer.from() extensively and getED25519Key returns Buffer types. The vue-example's App.vue still imports and calls getED25519Key, and the Vite config has no Buffer resolution or polyfill. This will cause a ReferenceError: Buffer is not defined at runtime in the browser when that code path is exercised.

Fix in Cursor Fix in Web

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants