-
Notifications
You must be signed in to change notification settings - Fork 11
Fix/security input validation #303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
shayla-develops-webs
wants to merge
12
commits into
main
Choose a base branch
from
fix/security-input-validation
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
7e27124
fix: escape user inputs in sendEmail.js to prevent HTML injection
shayla-develops-webs d326d5c
fix: replace dangerouslySetInnerHTML with plain text rendering in New…
shayla-develops-webs b11826c
fix: add server-side input validation in validateReCaptcha.js
shayla-develops-webs 6540a68
updated env variables
shayla-develops-webs 14e3d6a
Fix next-pwa import syntax for v2.x compatibility
shayla-develops-webs 2ca5be5
add client side email format validation to newsletter form to match s…
shayla-develops-webs 7cd02da
update changelog
shayla-develops-webs 4186251
Simplify conditional rendering logic in newsletter form
shayla-develops-webs b15015a
feat: introduce Zod validation with shared schemas for newsletter and…
shayla-develops-webs 41ac02c
chore: remove deprecated baseUrl from jsconfig
shayla-develops-webs d04cd1e
refactor: replace manual API validation with shared Zod schemas to ke…
shayla-develops-webs 6205123
docs: update changelog with Zod schemas, next-pwa fix, and server-sid…
shayla-develops-webs File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| import { z } from 'zod'; | ||
| import { newsletterSchema } from './newsletter'; | ||
|
|
||
| export const contactSchema = newsletterSchema.extend({ | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. My personal choice. I feel better to use z.object instead of newsletterSchema.extend as we can see all the fields in one file. |
||
| subject: z.string().min(2, 'Subject must be at least 2 characters'), | ||
| message: z | ||
| .string() | ||
| .min(2, 'Message must be at least 2 characters') | ||
| .max(5000, 'Message must be 5000 characters or less'), | ||
| subscribe: z.boolean().optional(), | ||
| }); | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| import { z } from 'zod'; | ||
|
|
||
| export const newsletterSchema = z.object({ | ||
| name: z | ||
| .string() | ||
| .min(2, 'Name must be at least 2 characters') | ||
| .max(80, 'Name must be 80 characters or less'), | ||
| email: z.string().email('Please enter a valid email address'), | ||
| }); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice to have: consider using RHF's register/reset here like ContactUsForm does, but out of scope for this PR — approving as-is.