Skip to content

Move stuff to API#2160

Merged
wrincewind merged 2 commits intoWayofTime:1.21.1from
stellanera98:api-refactor
Apr 9, 2026
Merged

Move stuff to API#2160
wrincewind merged 2 commits intoWayofTime:1.21.1from
stellanera98:api-refactor

Conversation

@stellanera98
Copy link
Copy Markdown
Contributor

moved stuff I think should be in /api there

not sure how to do something similar with:

  • attributes (self sacrifice boost)
  • data component types (binding, arc tool stats, living armour stuff, etc)
  • capabilities (rune stats)
  • data attachments? (not sure if needed but incense)

I also think at least parts of LivingHelper should be in api, but there stuff thats just there to make the effects work probably arent among them. Potentially split into "make it work" and "stuff you might wanna call from 'outside'".

Another thing is items/blocks etc. might be nice to have access to those in api so add-ons dont need to go look up the name. Potentially put the resource locations for those somewhere in api (and then use those to give the name to the deferred register? sounds halfway stupid to me but its an idea)

@dphaldes (less about code since its just renaming and moving stuff, more about the things mentioned above)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if this needs more suitable class name

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SoulNetworkBinding, SoulNetworkLink, BoundPlayer

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dont think this package belongs in API.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it might once the "real" rituals are done. might be a premature move though

Copy link
Copy Markdown
Contributor

@dphaldes dphaldes Dec 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exposing Util classes to API might not be a great idea. We probably don't want people to poke around it

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking it might be useful for things that are common in "ritual effects" to go there so addons can make use of it. the lightning strike, creating a predictable fake player for rituals doing stuff, interacting with ranges (though that should be on the range classes directly I think)
Any tailored thing would go with the ritual effect it belongs to directly

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happened to this class?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

they arent actually the sources but the damage types, renamed because of it and moved to api

@stellanera98 stellanera98 marked this pull request as ready for review April 9, 2026 05:18
@stellanera98
Copy link
Copy Markdown
Contributor Author

should be ready to merge now

@wrincewind wrincewind merged commit dd04a73 into WayofTime:1.21.1 Apr 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants